[PR #83] [CLOSED] Support for QApplication. #199

New issue

Closed

opened 2026-05-05 11:20:41 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:20:41 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/83
Author: @MaxMommersteeg
Created: 12/6/2018
Status: ❌ Closed

Base: develop ← Head: feature/support-qapplication

📝 Commits (3)

43a22ec Work in progress on supporting QApplication.
92e575d Set QApplication to interop.
4d5eafa Corrected incorrect variable name.

📊 Changes

7 files changed (+367 additions, -2 deletions)

View changed files

📝 src/native/QmlNet/Hosting/CoreHost.cpp (+85 -0)
📝 src/native/QmlNet/Hosting/CoreHost.h (+3 -0)
➕ src/native/QmlNet/QmlNet/qml/QApplication.cpp (+79 -0)
➕ src/native/QmlNet/QmlNet/qml/QApplication.h (+28 -0)
📝 src/native/QmlNet/QmlNet/qml/qml.pri (+2 -0)
📝 src/net/Qml.Net/Internal/Interop.cs (+6 -2)
➕ src/net/Qml.Net/QApplication.cs (+164 -0)

📄 Description

PR for issue https://github.com/qmlnet/qmlnet/issues/73.

Some classes are still using QGuiApplication:

Hosts.cs (Qml.Net project)
BaseQmlTests.cs (Qml.Net.Tests)

Should QApplication be the default in all tests? Or should I add seperate tests for QApplication and test both?

The run function in CoreHost.cpp is almost an exact copy. Perhaps we could remove one, re-use part of the method or allow passing in a more generic (base type or interface) QGuiApplication/QApplication.

Perhaps QApplication.cs and QGuiApplication.cs could implement an interface named IQCoreApplication?

All feedback is welcome, since C++ is not my main language.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/83 **Author:** [@MaxMommersteeg](https://github.com/MaxMommersteeg) **Created:** 12/6/2018 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `feature/support-qapplication` --- ### 📝 Commits (3) - [`43a22ec`](https://github.com/qmlnet/qmlnet/commit/43a22ec1e20412dfe26abb9fc577fe9fd317a035) Work in progress on supporting QApplication. - [`92e575d`](https://github.com/qmlnet/qmlnet/commit/92e575dd89f80e8877d6a8803757c8d51a93cee2) Set QApplication to interop. - [`4d5eafa`](https://github.com/qmlnet/qmlnet/commit/4d5eafa22ae1f012906fe2cd9ef2cfecc053982f) Corrected incorrect variable name. ### 📊 Changes **7 files changed** (+367 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/native/QmlNet/Hosting/CoreHost.cpp` (+85 -0) 📝 `src/native/QmlNet/Hosting/CoreHost.h` (+3 -0) ➕ `src/native/QmlNet/QmlNet/qml/QApplication.cpp` (+79 -0) ➕ `src/native/QmlNet/QmlNet/qml/QApplication.h` (+28 -0) 📝 `src/native/QmlNet/QmlNet/qml/qml.pri` (+2 -0) 📝 `src/net/Qml.Net/Internal/Interop.cs` (+6 -2) ➕ `src/net/Qml.Net/QApplication.cs` (+164 -0) </details> ### 📄 Description PR for issue https://github.com/qmlnet/qmlnet/issues/73. Some classes are still using QGuiApplication: - `Hosts.cs` (Qml.Net project) - `BaseQmlTests.cs` (Qml.Net.Tests) Should `QApplication` be the default in all tests? Or should I add seperate tests for `QApplication` and test both? The `run` function in CoreHost.cpp is almost an exact copy. Perhaps we could remove one, re-use part of the method or allow passing in a more generic (base type or interface) QGuiApplication/QApplication. Perhaps `QApplication.cs` and `QGuiApplication.cs` could implement an interface named `IQCoreApplication`? All feedback is welcome, since C++ is not my main language. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>