[PR #40] [MERGED] Implemented support for awaiting on tasks with results. #183

New issue

Closed

opened 2026-05-05 11:20:23 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:20:23 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/40
Author: @pauldotknopf
Created: 7/27/2018
Status: ✅ Merged
Merged: 7/27/2018
Merged by: @pauldotknopf

Base: master ← Head: task-await

📝 Commits (10+)

84e9b72 Added a new variant type "NetJsValue".
2fa3053 Added some tests for NetJsValue.
83af263 Checking in what I got. I've realized that something else needs to be done before I can continue.
46b416b Fixing build.
eab3916 Support for invoking the callbacks.
d6607d8 Support invoking callback with parameters.
965b6f0 Additional verifications.
aea560c Support passing .NET objects to callbacks.
bfde4aa Added support for passing javascript objects into javascript functions from .NET.
9acd70d Finished support for awaiting void tasks.

📊 Changes

23 files changed (+779 additions, -51 deletions)

View changed files

📝 src/native/QmlNet/QmlNet.h (+2 -1)
📝 src/native/QmlNet/QmlNet/qml/JsNetObject.cpp (+82 -0)
📝 src/native/QmlNet/QmlNet/qml/JsNetObject.h (+2 -0)
➕ src/native/QmlNet/QmlNet/qml/NetJsValue.cpp (+83 -0)
➕ src/native/QmlNet/QmlNet/qml/NetJsValue.h (+27 -0)
📝 src/native/QmlNet/QmlNet/qml/NetValue.cpp (+1 -1)
📝 src/native/QmlNet/QmlNet/qml/NetValueMetaObject.cpp (+15 -1)
📝 src/native/QmlNet/QmlNet/qml/NetVariant.cpp (+53 -3)
📝 src/native/QmlNet/QmlNet/qml/NetVariant.h (+5 -2)
📝 src/native/QmlNet/QmlNet/qml/qml.pri (+4 -2)
📝 src/native/QmlNet/QmlNet/types/Callbacks.cpp (+8 -0)
📝 src/native/QmlNet/QmlNet/types/Callbacks.h (+2 -0)
📝 src/net/Qml.Net.Sandbox/Program.UI.cs (+8 -30)
📝 src/net/Qml.Net.Sandbox/main.qml (+7 -7)
➕ src/net/Qml.Net.Tests/Qml/AwaitTests.cs (+122 -0)
➕ src/net/Qml.Net.Tests/Qml/JsValueTests.cs (+212 -0)
📝 src/net/Qml.Net/Internal/DefaultCallbacks.cs (+31 -0)
📝 src/net/Qml.Net/Internal/Helpers.cs (+5 -1)
📝 src/net/Qml.Net/Internal/Interop.cs (+5 -1)
➕ src/net/Qml.Net/Internal/Qml/NetJsValue.cs (+70 -0)

...and 3 more files

📄 Description

Closes #21

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/40 **Author:** [@pauldotknopf](https://github.com/pauldotknopf) **Created:** 7/27/2018 **Status:** ✅ Merged **Merged:** 7/27/2018 **Merged by:** [@pauldotknopf](https://github.com/pauldotknopf) **Base:** `master` ← **Head:** `task-await` --- ### 📝 Commits (10+) - [`84e9b72`](https://github.com/qmlnet/qmlnet/commit/84e9b726e7e43bacef3b2e759e6684736525d92b) Added a new variant type "NetJsValue". - [`2fa3053`](https://github.com/qmlnet/qmlnet/commit/2fa3053c5e1dbf829cf92a8f99c7d5de9916eed6) Added some tests for NetJsValue. - [`83af263`](https://github.com/qmlnet/qmlnet/commit/83af26384ba14f5ee33d65a5beb20af201ac66c8) Checking in what I got. I've realized that something else needs to be done before I can continue. - [`46b416b`](https://github.com/qmlnet/qmlnet/commit/46b416b0475da09c5d73f2a6e339bfffa249b833) Fixing build. - [`eab3916`](https://github.com/qmlnet/qmlnet/commit/eab39162867e10daa8d97b179aebebd9df323e85) Support for invoking the callbacks. - [`d6607d8`](https://github.com/qmlnet/qmlnet/commit/d6607d8ced68d74c834f5db57a567122f8106798) Support invoking callback with parameters. - [`965b6f0`](https://github.com/qmlnet/qmlnet/commit/965b6f0db057165bb486efdc1aff6b2109d6e182) Additional verifications. - [`aea560c`](https://github.com/qmlnet/qmlnet/commit/aea560c7f8a87432b4c9a69106bb6df010cd45c1) Support passing .NET objects to callbacks. - [`bfde4aa`](https://github.com/qmlnet/qmlnet/commit/bfde4aa4fef46090fb2d7c38188dfd282a45b219) Added support for passing javascript objects into javascript functions from .NET. - [`9acd70d`](https://github.com/qmlnet/qmlnet/commit/9acd70d10f6167746897abbdac1ee1f5ee0126c6) Finished support for awaiting void tasks. ### 📊 Changes **23 files changed** (+779 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `src/native/QmlNet/QmlNet.h` (+2 -1) 📝 `src/native/QmlNet/QmlNet/qml/JsNetObject.cpp` (+82 -0) 📝 `src/native/QmlNet/QmlNet/qml/JsNetObject.h` (+2 -0) ➕ `src/native/QmlNet/QmlNet/qml/NetJsValue.cpp` (+83 -0) ➕ `src/native/QmlNet/QmlNet/qml/NetJsValue.h` (+27 -0) 📝 `src/native/QmlNet/QmlNet/qml/NetValue.cpp` (+1 -1) 📝 `src/native/QmlNet/QmlNet/qml/NetValueMetaObject.cpp` (+15 -1) 📝 `src/native/QmlNet/QmlNet/qml/NetVariant.cpp` (+53 -3) 📝 `src/native/QmlNet/QmlNet/qml/NetVariant.h` (+5 -2) 📝 `src/native/QmlNet/QmlNet/qml/qml.pri` (+4 -2) 📝 `src/native/QmlNet/QmlNet/types/Callbacks.cpp` (+8 -0) 📝 `src/native/QmlNet/QmlNet/types/Callbacks.h` (+2 -0) 📝 `src/net/Qml.Net.Sandbox/Program.UI.cs` (+8 -30) 📝 `src/net/Qml.Net.Sandbox/main.qml` (+7 -7) ➕ `src/net/Qml.Net.Tests/Qml/AwaitTests.cs` (+122 -0) ➕ `src/net/Qml.Net.Tests/Qml/JsValueTests.cs` (+212 -0) 📝 `src/net/Qml.Net/Internal/DefaultCallbacks.cs` (+31 -0) 📝 `src/net/Qml.Net/Internal/Helpers.cs` (+5 -1) 📝 `src/net/Qml.Net/Internal/Interop.cs` (+5 -1) ➕ `src/net/Qml.Net/Internal/Qml/NetJsValue.cs` (+70 -0) _...and 3 more files_ </details> ### 📄 Description Closes #21 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>