[PR #9] [MERGED] exporting dll symbols for windows #167

New issue

Closed

opened 2026-05-05 11:20:02 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:20:02 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/qmlnet/qmlnet/pull/9
Author: @devmil
Created: 7/16/2018
Status: ✅ Merged
Merged: 7/16/2018
Merged by: @pauldotknopf

Base: master ← Head: windows_interop

📝 Commits (1)

c80f455 exporting dll symbols for windows

📊 Changes

13 files changed (+107 additions, -139 deletions)

View changed files

📝 src/native/QtNetCoreQml/QtNetCoreQml.h (+13 -12)
📝 src/native/QtNetCoreQml/QtNetCoreQml/qml/NetTestHelper.cpp (+2 -2)
📝 src/native/QtNetCoreQml/QtNetCoreQml/qml/NetVariant.cpp (+22 -22)
📝 src/native/QtNetCoreQml/QtNetCoreQml/qml/NetVariantList.cpp (+7 -7)
📝 src/native/QtNetCoreQml/QtNetCoreQml/qml/QGuiApplication.cpp (+6 -5)
📝 src/native/QtNetCoreQml/QtNetCoreQml/qml/QQmlApplicationEngine.cpp (+7 -41)
📝 src/native/QtNetCoreQml/QtNetCoreQml/types/Callbacks.cpp (+9 -9)
📝 src/native/QtNetCoreQml/QtNetCoreQml/types/NetInstance.cpp (+3 -3)
📝 src/native/QtNetCoreQml/QtNetCoreQml/types/NetMethodInfo.cpp (+12 -12)
📝 src/native/QtNetCoreQml/QtNetCoreQml/types/NetPropertyInfo.cpp (+8 -8)
📝 src/native/QtNetCoreQml/QtNetCoreQml/types/NetTypeInfo.cpp (+15 -15)
📝 src/native/QtNetCoreQml/QtNetCoreQml/types/NetTypeInfo.h (+1 -1)
📝 src/native/QtNetCoreQml/QtNetCoreQml/types/NetTypeManager.cpp (+2 -2)

📄 Description

Q_DECL_EXPORT for all entry points for the native library
removed not needed static definition (DEFINE_NETVALUETYPE), this part is already declared and defined in the header

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/qmlnet/qmlnet/pull/9 **Author:** [@devmil](https://github.com/devmil) **Created:** 7/16/2018 **Status:** ✅ Merged **Merged:** 7/16/2018 **Merged by:** [@pauldotknopf](https://github.com/pauldotknopf) **Base:** `master` ← **Head:** `windows_interop` --- ### 📝 Commits (1) - [`c80f455`](https://github.com/qmlnet/qmlnet/commit/c80f455185d6626e2b4b793bf8c064bc0a38ea4e) exporting dll symbols for windows ### 📊 Changes **13 files changed** (+107 additions, -139 deletions) <details> <summary>View changed files</summary> 📝 `src/native/QtNetCoreQml/QtNetCoreQml.h` (+13 -12) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/qml/NetTestHelper.cpp` (+2 -2) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/qml/NetVariant.cpp` (+22 -22) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/qml/NetVariantList.cpp` (+7 -7) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/qml/QGuiApplication.cpp` (+6 -5) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/qml/QQmlApplicationEngine.cpp` (+7 -41) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/types/Callbacks.cpp` (+9 -9) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/types/NetInstance.cpp` (+3 -3) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/types/NetMethodInfo.cpp` (+12 -12) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/types/NetPropertyInfo.cpp` (+8 -8) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/types/NetTypeInfo.cpp` (+15 -15) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/types/NetTypeInfo.h` (+1 -1) 📝 `src/native/QtNetCoreQml/QtNetCoreQml/types/NetTypeManager.cpp` (+2 -2) </details> ### 📄 Description Q_DECL_EXPORT for all entry points for the native library removed not needed static definition (DEFINE_NETVALUETYPE), this part is already declared and defined in the header --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>