github-starred/proton-native

Fork 0

mirror of https://github.com/kusti8/proton-native.git synced 2026-05-15 14:15:50 -06:00

[GH-ISSUE #127] Feature: Add native notifications support #78

New issue

Closed

opened 2026-05-05 11:38:14 -06:00 by gitea-mirror · 4 comments

gitea-mirror commented

2026-05-05 11:38:14 -06:00

Owner

Originally created by @bardiarastin on GitHub (May 14, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/127

Hello, awesome project 👏👏👏

I was able to add native OS notifications using https://github.com/mikaelbr/node-notifier

I'm thinking of that we can add this lib to project to have built in notification support simply by bridging.

I can make a PR for this if everything is okay with adding support for notifications, along side this, I have a lot of other ideas and things missing in this project like lack of support for printing for example...

Originally created by @bardiarastin on GitHub (May 14, 2018). Original GitHub issue: https://github.com/kusti8/proton-native/issues/127 Hello, awesome project 👏👏👏 I was able to add native OS notifications using https://github.com/mikaelbr/node-notifier ![image](https://user-images.githubusercontent.com/20615964/39989076-46170eac-577e-11e8-8d42-aeab10681826.png) I'm thinking of that we can add this lib to project to have built in notification support simply by bridging. I can make a PR for this if everything is okay with adding support for notifications, along side this, I have a lot of other ideas and things missing in this project like lack of support for printing for example...

gitea-mirror closed this issue

2026-05-05 11:38:18 -06:00

gitea-mirror commented

2026-05-05 11:38:22 -06:00

Author

Owner

@mischnic commented on GitHub (May 14, 2018):

Proton-native is based on libui, there is an issue for notifications there (https://github.com/andlabs/libui/issues/338), but it's not going to happen very soon (if ever): "I still don't know if this is in scope for libui."

printing for example

How should that work? What would you like to print? (PDFs, images?)

@mischnic commented on GitHub (May 14, 2018): Proton-native is based on [libui](https://github.com/andlabs/libui/issues), there is an issue for notifications there (https://github.com/andlabs/libui/issues/338), but it's not going to happen very soon (if ever): "I still don't know if this is in scope for libui." > printing for example How should that work? What would you like to print? (PDFs, images?)

gitea-mirror commented

2026-05-05 11:38:26 -06:00

Author

Owner

@bardiarastin commented on GitHub (May 14, 2018):

@mischnic
I taught that libui is only for UI stuff and nothing more so we should consider adding other extra stuff ourselves.
please let me know if you decided to do it in proton native I have ideas for performance of this (electron app with 3000 daily active users).

for printing there are some several functionalities needed. like a method to return OS printers, a method to print with options like which printer, page size, adjusting margins and...

what we needed was printing an html document in electron which we could make a browser window put html into that with whatever css we wanted then print it, along side support for image printing, I can make a separate issue for printing.

@bardiarastin commented on GitHub (May 14, 2018): @mischnic I taught that libui is only for UI stuff and nothing more so we should consider adding other extra stuff ourselves. please let me know if you decided to do it in proton native I have ideas for performance of this (electron app with 3000 daily active users). for printing there are some several functionalities needed. like a method to return OS printers, a method to print with options like which printer, page size, adjusting margins and... what we needed was printing an html document in electron which we could make a browser window put html into that with whatever css we wanted then print it, along side support for image printing, I can make a separate issue for printing.

gitea-mirror commented

2026-05-05 11:38:28 -06:00

Author

Owner

@mischnic commented on GitHub (May 14, 2018):

I taught that libui is only for UI stuff and nothing more so we should consider adding other extra stuff ourselves.

I would say that notifications are part of the ui.

please let me know if you decided to do it in proton native I have ideas for performance of this (electron app with 3000 daily active users).

With my previous comment I wanted to say: it should be done this way because it won't happen in libui.

What keeps you from using that library together with proton-native as it is?

for printing there are some several functionalities needed. like a method to return OS printers, a method to print with options like which printer, page size, adjusting margins and...

What about https://github.com/tojocky/node-printer ? (Haven't tested it myself)

@mischnic commented on GitHub (May 14, 2018): > I taught that libui is only for UI stuff and nothing more so we should consider adding other extra stuff ourselves. I would say that notifications are part of the ui. > please let me know if you decided to do it in proton native I have ideas for performance of this (electron app with 3000 daily active users). With my previous comment I wanted to say: it should be done this way because it won't happen in libui. What keeps you from using that library together with proton-native as it is? > for printing there are some several functionalities needed. like a method to return OS printers, a method to print with options like which printer, page size, adjusting margins and... What about https://github.com/tojocky/node-printer ? (Haven't tested it myself)

gitea-mirror commented

2026-05-05 11:38:31 -06:00

Author

Owner

@kusti8 commented on GitHub (May 14, 2018):

If there's no special thing that needs to be done on Proton Native to make it work, it's best if it's not merged. This leads to additional and additional libraries being merged just bloating the project. I can mention it in the documentation, but I'd rather not add another library.

@kusti8 commented on GitHub (May 14, 2018): If there's no special thing that needs to be done on Proton Native to make it work, it's best if it's not merged. This leads to additional and additional libraries being merged just bloating the project. I can mention it in the documentation, but I'd rather not add another library.

gitea-mirror referenced this issue

2026-05-05 11:56:58 -06:00

[PR #78] [MERGED] Area #251

gitea-mirror referenced this issue

2026-05-05 11:56:59 -06:00

[PR #90] [CLOSED] Bump libui-node dep to 0.2.0-rc1 #254