[GH-ISSUE #119] Why does this package depend on react-dom? #75

New issue

Closed

opened 2026-05-05 11:37:52 -06:00 by gitea-mirror · 2 comments

gitea-mirror commented

2026-05-05 11:37:52 -06:00

Owner

Originally created by @benwiley4000 on GitHub (May 10, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/119

I'm just wondering since the only reference to react-dom I could find is in the package.json, and it seems like that wouldn't be relevant here. I might have missed something!

Separately: I think react should be a peer dependency, not a normal dependency - this is generally the convention with React libraries since React breaks if more than one copy is running at a time.

Originally created by @benwiley4000 on GitHub (May 10, 2018). Original GitHub issue: https://github.com/kusti8/proton-native/issues/119 I'm just wondering since the only reference to react-dom I could find is in the package.json, and it seems like that wouldn't be relevant here. I might have missed something! Separately: I think react should be a peer dependency, not a normal dependency - this is generally the convention with React libraries since React breaks if more than one copy is running at a time.

gitea-mirror closed this issue

2026-05-05 11:37:53 -06:00

gitea-mirror commented

2026-05-05 11:37:55 -06:00

Author

Owner

@kusti8 commented on GitHub (May 11, 2018):

I agree that a peer dependency would be ideal, but create-proton-app would have to be updated as well to install react, as well as existing projects. If this becomes a large issue I'll change it, but for now I'll let it be a dependency.

@kusti8 commented on GitHub (May 11, 2018): I agree that a peer dependency would be ideal, but create-proton-app would have to be updated as well to install react, as well as existing projects. If this becomes a large issue I'll change it, but for now I'll let it be a dependency.

gitea-mirror commented

2026-05-05 11:37:58 -06:00

Author

Owner

@benwiley4000 commented on GitHub (May 11, 2018):

I agree with that - I think it should be scheduled for the next major
release (2.0). Since breaking changes are expected, it's a fair time to
make it required as an external dependency.

Le ven. 11 mai 2018 18 h 15, Gustav Hansen notifications@github.com a
écrit :

I agree that a peer dependency would be ideal, but create-proton-app would
have to be updated as well to install react, as well as existing projects.
If this becomes a large issue I'll change it, but for now I'll let it be a
dependency.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kusti8/proton-native/issues/119#issuecomment-388499007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM7h7X8X_uWV_KzdIpM3Rvu5K12porooks5txg11gaJpZM4T6tS8
.

@benwiley4000 commented on GitHub (May 11, 2018): I agree with that - I think it should be scheduled for the next major release (2.0). Since breaking changes are expected, it's a fair time to make it required as an external dependency. Le ven. 11 mai 2018 18 h 15, Gustav Hansen <notifications@github.com> a écrit : > I agree that a peer dependency would be ideal, but create-proton-app would > have to be updated as well to install react, as well as existing projects. > If this becomes a large issue I'll change it, but for now I'll let it be a > dependency. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/kusti8/proton-native/issues/119#issuecomment-388499007>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AM7h7X8X_uWV_KzdIpM3Rvu5K12porooks5txg11gaJpZM4T6tS8> > . >