github-starred/proton-native

Fork 0

mirror of https://github.com/kusti8/proton-native.git synced 2026-05-15 22:02:24 -06:00

[GH-ISSUE #108] onChange on initial start #65

New issue

Closed

opened 2026-05-05 11:36:47 -06:00 by gitea-mirror · 6 comments

gitea-mirror commented

2026-05-05 11:36:47 -06:00

Owner

Originally created by @mischnic on GitHub (May 5, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/108

The onChanged event gets emitted when rendering the element for the first time (without any user interaction).

import React, { Component } from 'react';
import { render, Window, App, Entry, Box, ColorButton } from './src';

class Example extends Component {
  render() {
    return (
      <App>
        <Window
          title="Proton Native Rocks!"
          size={{ w: 300, h: 300 }}
          menuBar={false}
        >
          <Entry onChange={a => console.log(a)}>Some Text</Entry>
        </Window>
      </App>
    );
  }
}

render(<Example />);

Without typing anything:

$ npx babel-node test.js
Some Text

Originally created by @mischnic on GitHub (May 5, 2018). Original GitHub issue: https://github.com/kusti8/proton-native/issues/108 The onChanged event gets emitted when rendering the element for the first time (without any user interaction). ```jsx import React, { Component } from 'react'; import { render, Window, App, Entry, Box, ColorButton } from './src'; class Example extends Component { render() { return ( <App> <Window title="Proton Native Rocks!" size={{ w: 300, h: 300 }} menuBar={false} > <Entry onChange={a => console.log(a)}>Some Text</Entry> </Window> </App> ); } } render(<Example />); ``` Without typing anything: ``` $ npx babel-node test.js Some Text ```

gitea-mirror closed this issue

2026-05-05 11:36:49 -06:00

gitea-mirror commented

2026-05-05 11:36:51 -06:00

Author

Owner

@kusti8 commented on GitHub (May 5, 2018):

I suspect this is due to the fact that it creates the onCreate callback before setting the text, simply because that's the order the props are given in. There really isn't an easy way to do this, unless you manually change the prop order which is a bit of a hack.

@kusti8 commented on GitHub (May 5, 2018): I suspect this is due to the fact that it creates the onCreate callback before setting the text, simply because that's the order the props are given in. There really isn't an easy way to do this, unless you manually change the prop order which is a bit of a hack.

gitea-mirror commented

2026-05-05 11:36:54 -06:00

Author

Owner

@mischnic commented on GitHub (May 5, 2018):

I suspect this is due to the fact that it creates the onCreate callback

onChange gets fired in DesktopComponent.initialProps:

d37dae1299/src/components/DesktopComponent.js (L200-L213)

@mischnic commented on GitHub (May 5, 2018): > I suspect this is due to the fact that it creates the onCreate callback `onChange` gets fired in `DesktopComponent.initialProps`: https://github.com/kusti8/proton-native/blob/d37dae1299527cfc51905b8eccdc1d398ebe413f/src/components/DesktopComponent.js#L200-L213

gitea-mirror commented

2026-05-05 11:36:56 -06:00

Author

Owner

@kusti8 commented on GitHub (May 5, 2018):

Yeah so once it sets the onChange callback, it sets the children as well. So if libui fires onChange when the text property is set, then that may be it. I still have to try it out and see.

@kusti8 commented on GitHub (May 5, 2018): Yeah so once it sets the onChange callback, it sets the children as well. So if libui fires onChange when the text property is set, then that may be it. I still have to try it out and see.

gitea-mirror commented

2026-05-05 11:36:59 -06:00

Author

Owner

@mischnic commented on GitHub (May 5, 2018):

It's libui-node('s "fault"):

void UiEntryBase::setText(std::string text) {
	uiEntrySetText(uiEntry(getHandle()), text.c_str());
	if (onChangedCallback != NULL) {
		(*onChangedCallback)();
	}
}

libui itself doesn't call onChanged with setText.

@mischnic commented on GitHub (May 5, 2018): It's libui-node('s "fault"): ```cpp void UiEntryBase::setText(std::string text) { uiEntrySetText(uiEntry(getHandle()), text.c_str()); if (onChangedCallback != NULL) { (*onChangedCallback)(); } } ``` libui itself doesn't call `onChanged` with `setText`.

gitea-mirror commented

2026-05-05 11:37:01 -06:00

Author

Owner

@kusti8 commented on GitHub (May 6, 2018):

Yeah that makes sense. It's not that big of a deal and it would be ugly to fix it in proton-native. For some applications that store the value, it may be desirable so that you get the default value, others not so much.

@kusti8 commented on GitHub (May 6, 2018): Yeah that makes sense. It's not that big of a deal and it would be ugly to fix it in proton-native. For some applications that store the value, it may be desirable so that you get the default value, others not so much.

gitea-mirror commented

2026-05-05 11:37:03 -06:00

Author

Owner

@parro-it commented on GitHub (May 7, 2018):

We can remove the callback change from the setter of property if you think it can improve things.

@parro-it commented on GitHub (May 7, 2018): We can remove the callback change from the setter of property if you think it can improve things.