[GH-ISSUE #71] Menu Buttons not working (Quit, About, Preferences) #41

Closed
opened 2026-05-05 11:31:14 -06:00 by gitea-mirror · 5 comments
Owner

Originally created by @MarkRabey on GitHub (Mar 29, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/71

Setting type on Menu.Item to Quit, About, or Preference does not have the desired effect. The items do not appear in the menu. When Quit is used, using Command+Q does quit the app. So, it's at least partly working I suppose.

The issue also exists in the sample Notepad app.

Originally created by @MarkRabey on GitHub (Mar 29, 2018). Original GitHub issue: https://github.com/kusti8/proton-native/issues/71 Setting `type` on `Menu.Item` to `Quit`, `About`, or `Preference` does not have the desired effect. The items do not appear in the menu. When `Quit` is used, using Command+Q _does_ quit the app. So, it's at least partly working I suppose. The issue also exists in the sample Notepad app.
Author
Owner

@mischnic commented on GitHub (Mar 29, 2018):

Is that on macOS, Windows or Linux?

<!-- gh-comment-id:377252957 --> @mischnic commented on GitHub (Mar 29, 2018): Is that on macOS, Windows or Linux?
Author
Owner

@MarkRabey commented on GitHub (Mar 29, 2018):

Sorry, I'm on Mac.

<!-- gh-comment-id:377255195 --> @MarkRabey commented on GitHub (Mar 29, 2018): Sorry, I'm on Mac.
Author
Owner

@mischnic commented on GitHub (Mar 29, 2018):

On Mac, these items go into the application menu:

without About and Preferences
bildschirmfoto 2018-03-29 um 16 37 18

with them:
bildschirmfoto 2018-03-29 um 16 37 35

<!-- gh-comment-id:377256214 --> @mischnic commented on GitHub (Mar 29, 2018): On Mac, these items go into the application menu: without `About` and `Preferences` ![bildschirmfoto 2018-03-29 um 16 37 18](https://user-images.githubusercontent.com/4586894/38094973-8bc99eca-336f-11e8-8a9e-54ae2832f54a.png) with them: ![bildschirmfoto 2018-03-29 um 16 37 35](https://user-images.githubusercontent.com/4586894/38094974-8bedf3e2-336f-11e8-8c09-16654fdd5870.png)
Author
Owner

@MarkRabey commented on GitHub (Mar 29, 2018):

Wow! Just like every other Mac app! No idea how I missed that...LOL Thanks!

<!-- gh-comment-id:377260955 --> @MarkRabey commented on GitHub (Mar 29, 2018): Wow! Just like every other Mac app! No idea how I missed that...LOL Thanks!
Author
Owner

@sirajulm commented on GitHub (May 17, 2019):

@mischnic Thank you for the solution. But I dont find a way to change the title of About Menu Item, it still shows About node. Tried adding text as children, and tried attributes, title and label, but it didnt help.

<!-- gh-comment-id:493385068 --> @sirajulm commented on GitHub (May 17, 2019): @mischnic Thank you for the solution. But I dont find a way to change the title of About Menu Item, it still shows `About node`. Tried adding text as `children`, and tried attributes, `title` and `label`, but it didnt help.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/proton-native#41
No description provided.