mirror of
https://github.com/kusti8/proton-native.git
synced 2026-05-15 14:15:50 -06:00
[GH-ISSUE #55] Grid does not work on macOS #33
Labels
No labels
bug
documentation
enhancement
libui issue
pull-request
question
wait for libui implementation
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/proton-native#33
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @maximecolin on GitHub (Mar 17, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/55
I tried the Grid example given in the doc. I guess the two components should be displayed one next to the other, but only the first cell is displayed.
@mischnic commented on GitHub (Mar 17, 2018):
Works on Windows 10
@andlabs commented on GitHub (Mar 19, 2018):
Grid does work on macOS; it's just insanely buggy because either Auto Layout is hard or my attempt at making a grid with it is poor (probably the latter), so it only works under specific circumstances... This is an active problem. What should that example look like?
@mischnic commented on GitHub (Mar 19, 2018):
Windows 10:
@kusti8 commented on GitHub (Mar 19, 2018):
@andlabs I don't know if it would be easier, but yoga is an option as well for layout similar to grid (css introduced flexbox because grids became cumbersome).
@mischnic commented on GitHub (Apr 29, 2018):
Actually, flexbox came first because tables were too cumbersome 😄. CSS Grid Layout is the newest of them all.
@shayneoneill commented on GitHub (Jul 29, 2018):
Was a solution ever found? Its bit of a show stopper
@andlabs commented on GitHub (Jul 29, 2018):
The proper solution would be to fix Grid. There is the idea of using Yoga, but that would require not only a third party dependency but also a fixed view. I'm not sure if I want to include that in libui for reasons I have to explain in detail, but I'm not sure what prevents one from being written outside of libui itself.
@mischnic commented on GitHub (Jul 29, 2018):
With a fixed view in libui, Yoga can be implement on the javascript side (as already done in https://github.com/kusti8/proton-native/pull/76). What do you mean by "one from being written outside of libui itself" - the fixed view or yoga?
@andlabs commented on GitHub (Jul 29, 2018):
Does proton-native have any C code other than libui?
@mischnic commented on GitHub (Jul 29, 2018):
Proton-native itself has no native code at all, it's just another Javascript wrapper around libui-node.
@kusti8 commented on GitHub (Jul 29, 2018):
Yoga is C code, but has a JS wrapper around that. My branch wraps and
manages yoga, using my fixed API.
On Sun, Jul 29, 2018, 6:02 PM Niklas Mischkulnig notifications@github.com
wrote:
@kusti8 commented on GitHub (Jan 19, 2020):
Proton Native V2 is now released! If the issue still occurs in the new update, please open a new issue.
@andlabs commented on GitHub (Jan 19, 2020):
(If you actually fixed these issues please push them upstream; I'll be writing a test suite to ensure things don't fall apart)
@mischnic commented on GitHub (Jan 19, 2020):
(V2 uses a purpose-built Qt binding instead of libui[-node].)
@andlabs commented on GitHub (Jan 20, 2020):
Very well, thanks in the meantime!