[GH-ISSUE #58] Standard menu item are showed are checkbox menu. #32

New issue

Closed

opened 2026-05-05 11:29:34 -06:00 by gitea-mirror · 3 comments

gitea-mirror commented

2026-05-05 11:29:34 -06:00

Owner

Originally created by @parro-it on GitHub (Mar 19, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/58

It appears that they are added as standard menu item,
but then switched to check when checked property is set to default value of false here: https://github.com/kusti8/proton-native/blob/master/src/components/MenuBar.js#L74

Commenting this line make menu items appear as they should.
I don't know why libui change the menu item type once constructed, anyway, seems better to just remove the property setting on proton side, since a default menu item does not have the prop.

Originally created by @parro-it on GitHub (Mar 19, 2018). Original GitHub issue: https://github.com/kusti8/proton-native/issues/58 It appears that they are added as standard menu item, but then switched to check when `checked` property is set to default value of `false` here: https://github.com/kusti8/proton-native/blob/master/src/components/MenuBar.js#L74 Commenting this line make menu items appear as they should. I don't know why `libui` change the menu item type once constructed, anyway, seems better to just remove the property setting on proton side, since a default menu item does not have the prop.

gitea-mirror closed this issue

2026-05-05 11:29:37 -06:00

gitea-mirror commented

2026-05-05 11:29:42 -06:00

Author

Owner

@parro-it commented on GitHub (Mar 19, 2018):

Should be solved by #57

@parro-it commented on GitHub (Mar 19, 2018): Should be solved by #57

gitea-mirror commented

2026-05-05 11:29:44 -06:00

Author

Owner

@kusti8 commented on GitHub (Mar 19, 2018):

Interesting. Thanks.

@kusti8 commented on GitHub (Mar 19, 2018): Interesting. Thanks.

gitea-mirror commented

2026-05-05 11:29:47 -06:00

Author

Owner

@mischnic commented on GitHub (Mar 19, 2018):

Basically the same problem as with https://github.com/kusti8/proton-native/pull/56.

@mischnic commented on GitHub (Mar 19, 2018): Basically the same problem as with https://github.com/kusti8/proton-native/pull/56.

gitea-mirror referenced this issue

2026-05-05 11:56:20 -06:00

[PR #32] [MERGED] Fix notepad example [Update methods to new component API] #233