[PR #307] Add flags prop to Window (Qt only) #317

New issue

Open

opened 2026-05-05 11:58:57 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:58:57 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kusti8/proton-native/pull/307
Author: @maciek134
Created: 8/13/2020
Status: 🔄 Open

Base: master ← Head: feat/window-flags

📝 Commits (1)

af0a451 Add flags prop to Window (Qt only)

📊 Changes

4 files changed (+116 additions, -337 deletions)

View changed files

📝 package-lock.json (+100 -333)
📝 package.json (+1 -1)
📝 src/backends/qt.ts (+3 -0)
📝 src/components/Window.ts (+12 -3)

📄 Description

Depends on https://github.com/kusti8/node-qt-napi/pull/7.

This is more of a conversation starter than a mergable PR, because it would probably be a good idea to add this to Wx as well (most of the useful flags should overlap, so there would only be a small translation between Qt/Wx needed), or even go higher level and add Window props like frame, dialog, etc.

Let me know what you think.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kusti8/proton-native/pull/307 **Author:** [@maciek134](https://github.com/maciek134) **Created:** 8/13/2020 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feat/window-flags` --- ### 📝 Commits (1) - [`af0a451`](https://github.com/kusti8/proton-native/commit/af0a451bd9e98326f5437f131fa4976e280a72c8) Add flags prop to Window (Qt only) ### 📊 Changes **4 files changed** (+116 additions, -337 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+100 -333) 📝 `package.json` (+1 -1) 📝 `src/backends/qt.ts` (+3 -0) 📝 `src/components/Window.ts` (+12 -3) </details> ### 📄 Description Depends on https://github.com/kusti8/node-qt-napi/pull/7. This is more of a conversation starter than a mergable PR, because it would probably be a good idea to add this to Wx as well (most of the useful flags should overlap, so there would only be a small translation between Qt/Wx needed), or even go higher level and add Window props like `frame`, `dialog`, etc. Let me know what you think. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>