mirror of
https://github.com/kusti8/proton-native.git
synced 2026-05-15 14:15:50 -06:00
[PR #255] [MERGED] Fix types for intrinsic elements #300
Labels
No labels
bug
documentation
enhancement
libui issue
pull-request
question
wait for libui implementation
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/proton-native#300
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/kusti8/proton-native/pull/255
Author: @CKH4
Created: 1/23/2020
Status: ✅ Merged
Merged: 1/30/2020
Merged by: @kusti8
Base:
master← Head:fix/jsx-intrinsic-elements-types📝 Commits (1)
72aee4cFix types for intrinsic elements📊 Changes
11 files changed (+128 additions, -56 deletions)
View changed files
📝
src/components/App.ts(+11 -1)📝
src/components/Button.ts(+15 -5)📝
src/components/Image.ts(+20 -8)📝
src/components/PickerInternal.ts(+15 -5)📝
src/components/RootText.ts(+7 -7)📝
src/components/TextInput.ts(+16 -6)📝
src/components/View.ts(+19 -9)📝
src/components/VirtualText.ts(+6 -6)📝
src/components/Window.ts(+14 -4)📝
src/components/YogaComponent.ts(+1 -1)📝
src/utils/propChecker.ts(+4 -4)📄 Description
Intrinsic elements are now properly typed
Previously the intrinsic elements provided by proton-native (Window, View, App, VirtualText, RootText, Image, TextInput, PickerInternal, Button) had few or no types associated with them. This made it difficult to use proton-native in typescript projects
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.