[PR #133] [MERGED] Add min and max for slider #272

New issue

Closed

opened 2026-05-05 11:57:39 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:57:39 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kusti8/proton-native/pull/133
Author: @kusti8
Created: 5/16/2018
Status: ✅ Merged
Merged: 5/21/2018
Merged by: @kusti8

Base: master ← Head: slider-minmax

📝 Commits (6)

b613b2a Add min max support for slider
c6af16c Reset demo
16ed2d7 Don't destroy children elements for slider
983943f Prevent slider from resetting when recreated
c9598f4 Reset value for slider when beyond max or min. Cleanup code
0766636 Add to documentation

📊 Changes

3 files changed (+98 additions, -19 deletions)

View changed files

📝 docs/component_APIs/slider.md (+35 -17)
📝 src/components/DesktopComponent.js (+31 -1)
📝 src/components/Slider.js (+32 -1)

📄 Description

Fixes #131. Had to do some weird stuff, mainly removing all the children of the Slider's parent in libui, remaking the slider, and then adding back all of those children, which I want to test more thoroughly before I merge.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kusti8/proton-native/pull/133 **Author:** [@kusti8](https://github.com/kusti8) **Created:** 5/16/2018 **Status:** ✅ Merged **Merged:** 5/21/2018 **Merged by:** [@kusti8](https://github.com/kusti8) **Base:** `master` ← **Head:** `slider-minmax` --- ### 📝 Commits (6) - [`b613b2a`](https://github.com/kusti8/proton-native/commit/b613b2a95ab67847c9eb50431f45ad3e450131aa) Add min max support for slider - [`c6af16c`](https://github.com/kusti8/proton-native/commit/c6af16c1991cf74024378b3d6086534f45e14921) Reset demo - [`16ed2d7`](https://github.com/kusti8/proton-native/commit/16ed2d71ce1377b158aa46f135fb9ec556ac5d0f) Don't destroy children elements for slider - [`983943f`](https://github.com/kusti8/proton-native/commit/983943fe31ce22ed2f6465f4305ff23a6054623c) Prevent slider from resetting when recreated - [`c9598f4`](https://github.com/kusti8/proton-native/commit/c9598f4a4207e7954dd700d746407f677e7340b9) Reset value for slider when beyond max or min. Cleanup code - [`0766636`](https://github.com/kusti8/proton-native/commit/07666360eb3e63961316ccf5a414779c7f6ab42f) Add to documentation ### 📊 Changes **3 files changed** (+98 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `docs/component_APIs/slider.md` (+35 -17) 📝 `src/components/DesktopComponent.js` (+31 -1) 📝 `src/components/Slider.js` (+32 -1) </details> ### 📄 Description Fixes #131. Had to do some weird stuff, mainly removing all the children of the Slider's parent in libui, remaking the slider, and then adding back all of those children, which I want to test more thoroughly before I merge. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>