[PR #126] [MERGED] Area fixup #268

New issue

Closed

opened 2026-05-05 11:57:27 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:57:27 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kusti8/proton-native/pull/126
Author: @mischnic
Created: 5/13/2018
Status: ✅ Merged
Merged: 5/18/2018
Merged by: @kusti8

Base: master ← Head: area_fix

📝 Commits (5)

46bc830 Area fixup
b214a92 Translate key event paramters
2c2dba4 More fixups
17a6b40 Add count to mousedown
6a7066d Merge branch 'master' into area_fix

📊 Changes

3 files changed (+146 additions, -86 deletions)

View changed files

📝 docs/component_APIs/area.md (+17 -11)
📝 examples/area.js (+14 -3)
📝 src/components/Area.js (+115 -72)

📄 Description

Functional changes:

onMouseUp works correctly now
onMouseDown now has access to the click count (e.g. for double clicks)
the modifier and extKey parameters of the key events get translated from a number into string(s)
missing cast in transform=scale

Otherwise:

using enums instead of magic numbers
calling free methods

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kusti8/proton-native/pull/126 **Author:** [@mischnic](https://github.com/mischnic) **Created:** 5/13/2018 **Status:** ✅ Merged **Merged:** 5/18/2018 **Merged by:** [@kusti8](https://github.com/kusti8) **Base:** `master` ← **Head:** `area_fix` --- ### 📝 Commits (5) - [`46bc830`](https://github.com/kusti8/proton-native/commit/46bc8300c1e3af3e6d2d707982687be057999688) Area fixup - [`b214a92`](https://github.com/kusti8/proton-native/commit/b214a9250d4c197b6dfe8552135d6e92905589b8) Translate key event paramters - [`2c2dba4`](https://github.com/kusti8/proton-native/commit/2c2dba4c31c0bdfb3625104eee135d3d634919d9) More fixups - [`17a6b40`](https://github.com/kusti8/proton-native/commit/17a6b404f089f4aad417ee0b0296ab13c8d9f22c) Add count to mousedown - [`6a7066d`](https://github.com/kusti8/proton-native/commit/6a7066dd6e264d31a9836b57033a650a9ff12ef1) Merge branch 'master' into area_fix ### 📊 Changes **3 files changed** (+146 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `docs/component_APIs/area.md` (+17 -11) 📝 `examples/area.js` (+14 -3) 📝 `src/components/Area.js` (+115 -72) </details> ### 📄 Description Functional changes: - `onMouseUp` works correctly now - `onMouseDown` now has access to the click count (e.g. for double clicks) - the modifier and extKey parameters of the key events get translated from a number into string(s) - missing cast in transform=scale Otherwise: - using enums instead of magic numbers - calling free methods --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>