[PR #56] [MERGED] Fix crash with Quit menu item on Windows #243

Closed
opened 2026-05-05 11:56:42 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/kusti8/proton-native/pull/56
Author: @mischnic
Created: 3/18/2018
Status: Merged
Merged: 3/18/2018
Merged by: @kusti8

Base: masterHead: win-quit


📝 Commits (2)

  • c07607b Fix crash with Quit menu item on Windows
  • 4b74afb Bump version

📊 Changes

3 files changed (+1658 additions, -707 deletions)

View changed files

📝 package-lock.json (+1650 -700)
📝 package.json (+8 -6)
📝 src/components/MenuBar.js (+0 -1)

📄 Description

Fixes #18

Making the Quit item actually quit the application will be added when libui-node 0.1.0 is released (WIP at https://github.com/mischnic/proton-native/tree/libui-node-010).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/kusti8/proton-native/pull/56 **Author:** [@mischnic](https://github.com/mischnic) **Created:** 3/18/2018 **Status:** ✅ Merged **Merged:** 3/18/2018 **Merged by:** [@kusti8](https://github.com/kusti8) **Base:** `master` ← **Head:** `win-quit` --- ### 📝 Commits (2) - [`c07607b`](https://github.com/kusti8/proton-native/commit/c07607baa0c5f506810e3a110342e54acb7ab937) Fix crash with Quit menu item on Windows - [`4b74afb`](https://github.com/kusti8/proton-native/commit/4b74afb9b7313044ef9eb82147213886b295e3d1) Bump version ### 📊 Changes **3 files changed** (+1658 additions, -707 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+1650 -700) 📝 `package.json` (+8 -6) 📝 `src/components/MenuBar.js` (+0 -1) </details> ### 📄 Description Fixes #18 Making the Quit item actually quit the application will be added when libui-node 0.1.0 is released (WIP at https://github.com/mischnic/proton-native/tree/libui-node-010). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 11:56:42 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/proton-native#243
No description provided.