[PR #40] [MERGED] Make python hello-world example comparable to proton example #237

New issue

Closed

opened 2026-05-05 11:56:30 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:56:30 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kusti8/proton-native/pull/40
Author: @cjrh
Created: 3/3/2018
Status: ✅ Merged
Merged: 3/3/2018
Merged by: @kusti8

Base: master ← Head: comparable-pyqt-example

📝 Commits (1)

6c783b1 Make python hello-world example comparable to proton example

📊 Changes

1 file changed (+9 additions, -27 deletions)

View changed files

📝 docs/python_example.py (+9 -27)

📄 Description

I removed the odd double-line spacing in the class between print_hello() and initUI(), and also refactored out the call to initUI because it typically isn't used in smaller apps. I also reduced outer-scope line gaps to single-space, rather than double space because this is what the proton example uses.

Is the btn.move(50, 50) necessary? The proton example code doesn't have this, but it might use a default style that produces a similar effect? Dunno. If you want it back in I will add it.

Proton Native looks really neat, good job!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kusti8/proton-native/pull/40 **Author:** [@cjrh](https://github.com/cjrh) **Created:** 3/3/2018 **Status:** ✅ Merged **Merged:** 3/3/2018 **Merged by:** [@kusti8](https://github.com/kusti8) **Base:** `master` ← **Head:** `comparable-pyqt-example` --- ### 📝 Commits (1) - [`6c783b1`](https://github.com/kusti8/proton-native/commit/6c783b1d1d1677f3ea61858519afa19a7acb449d) Make python hello-world example comparable to proton example ### 📊 Changes **1 file changed** (+9 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `docs/python_example.py` (+9 -27) </details> ### 📄 Description I removed the odd double-line spacing in the class between `print_hello()` and `initUI()`, and also refactored out the call to `initUI` because it typically isn't used in smaller apps. I also reduced outer-scope line gaps to single-space, rather than double space because this is what the proton example uses. Is the `btn.move(50, 50)` necessary? The proton example code doesn't have this, but it might use a default style that produces a similar effect? Dunno. If you want it back in I will add it. Proton Native looks really neat, good job! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>