[PR #25] [MERGED] remove multiple if statements from Dialog component #228

Closed
opened 2026-05-05 11:56:10 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/kusti8/proton-native/pull/25
Author: @alejandronanez
Created: 2/19/2018
Status: Merged
Merged: 2/26/2018
Merged by: @kusti8

Base: masterHead: update-dialog-component


📝 Commits (3)

  • 367e1af remove multiple if statements from Dialog component
  • 90dd244 update typo
  • edc33d0 add return statement

📊 Changes

1 file changed (+24 additions, -13 deletions)

View changed files

📝 src/components/Dialog.js (+24 -13)

📄 Description

Initial cleanup for Dialog component. The less IFs we have, the better :)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/kusti8/proton-native/pull/25 **Author:** [@alejandronanez](https://github.com/alejandronanez) **Created:** 2/19/2018 **Status:** ✅ Merged **Merged:** 2/26/2018 **Merged by:** [@kusti8](https://github.com/kusti8) **Base:** `master` ← **Head:** `update-dialog-component` --- ### 📝 Commits (3) - [`367e1af`](https://github.com/kusti8/proton-native/commit/367e1af32b0733710632c1b2d8431249b0fb114f) remove multiple if statements from Dialog component - [`90dd244`](https://github.com/kusti8/proton-native/commit/90dd244f4b37006e8e4874314380bd15038c5489) update typo - [`edc33d0`](https://github.com/kusti8/proton-native/commit/edc33d0ecd04612bbc49afb9a8b2c3b41b843570) add return statement ### 📊 Changes **1 file changed** (+24 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/components/Dialog.js` (+24 -13) </details> ### 📄 Description Initial cleanup for Dialog component. The less IFs we have, the better :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 11:56:10 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/proton-native#228
No description provided.