[PR #15] [CLOSED] Use React event naming conventions #224

New issue

Closed

opened 2026-05-05 11:56:01 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 11:56:01 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kusti8/proton-native/pull/15
Author: @orinamio
Created: 2/17/2018
Status: ❌ Closed

Base: master ← Head: change-to-react-event-naming-convention

📝 Commits (1)

7a81d41 Use React event naming conventions

📊 Changes

35 files changed (+90 additions, -90 deletions)

View changed files

📝 bin/components/Button.js (+3 -3)
📝 bin/components/ColorButton.js (+3 -3)
📝 bin/components/EditableCombobox.js (+3 -3)
📝 bin/components/Entry.js (+3 -3)
📝 bin/components/FontButton.js (+3 -3)
📝 bin/components/MenuBar.js (+3 -3)
📝 bin/components/MultilineEntry.js (+3 -3)
📝 bin/components/PasswordEntry.js (+3 -3)
📝 bin/components/Slider.js (+3 -3)
📝 bin/components/Spinbox.js (+3 -3)
📝 bin/components/Window.js (+4 -4)
📝 docs/README.md (+1 -1)
📝 docs/component_APIs/button.md (+2 -2)
📝 docs/component_APIs/color_button.md (+2 -2)
📝 docs/component_APIs/menu_item.md (+2 -2)
📝 docs/component_APIs/picker.md (+1 -1)
📝 docs/component_APIs/slider.md (+2 -2)
📝 docs/component_APIs/spinbox.md (+2 -2)
📝 docs/component_APIs/textinput.md (+2 -2)
📝 docs/component_APIs/window.md (+2 -2)

...and 15 more files

📄 Description

In React, events are typically called onChange and onClick rather than onChanged and onClicked. Response to gaearon issue - Use React event naming conventions #9

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kusti8/proton-native/pull/15 **Author:** [@orinamio](https://github.com/orinamio) **Created:** 2/17/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `change-to-react-event-naming-convention` --- ### 📝 Commits (1) - [`7a81d41`](https://github.com/kusti8/proton-native/commit/7a81d41c2163c2d4f6f14fd862c077accc79f4be) Use React event naming conventions ### 📊 Changes **35 files changed** (+90 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `bin/components/Button.js` (+3 -3) 📝 `bin/components/ColorButton.js` (+3 -3) 📝 `bin/components/EditableCombobox.js` (+3 -3) 📝 `bin/components/Entry.js` (+3 -3) 📝 `bin/components/FontButton.js` (+3 -3) 📝 `bin/components/MenuBar.js` (+3 -3) 📝 `bin/components/MultilineEntry.js` (+3 -3) 📝 `bin/components/PasswordEntry.js` (+3 -3) 📝 `bin/components/Slider.js` (+3 -3) 📝 `bin/components/Spinbox.js` (+3 -3) 📝 `bin/components/Window.js` (+4 -4) 📝 `docs/README.md` (+1 -1) 📝 `docs/component_APIs/button.md` (+2 -2) 📝 `docs/component_APIs/color_button.md` (+2 -2) 📝 `docs/component_APIs/menu_item.md` (+2 -2) 📝 `docs/component_APIs/picker.md` (+1 -1) 📝 `docs/component_APIs/slider.md` (+2 -2) 📝 `docs/component_APIs/spinbox.md` (+2 -2) 📝 `docs/component_APIs/textinput.md` (+2 -2) 📝 `docs/component_APIs/window.md` (+2 -2) _...and 15 more files_ </details> ### 📄 Description In React, events are typically called onChange and onClick rather than onChanged and onClicked. Response to `gaearon` issue - Use React event naming conventions #9 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>