[GH-ISSUE #191] componentWillUnmount is not called #124

New issue

Closed

opened 2026-05-05 11:46:11 -06:00 by gitea-mirror · 2 comments

gitea-mirror commented

2026-05-05 11:46:11 -06:00

Owner

Originally created by @unlight on GitHub (Dec 30, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/191

I just written simple hello world application using proton native.
And I'm wondering why componentWillUnmount is not called, when:

I'm doing Quit
Closing main window

Is it by design?
I've pasted console.log in these methods.
componentDidMount is working fine.

Win10 Node v10.12.0
`-- proton-native@1.1.10
  `-- libui-node@0.2.1

Originally created by @unlight on GitHub (Dec 30, 2018). Original GitHub issue: https://github.com/kusti8/proton-native/issues/191 I just written simple hello world application using proton native. And I'm wondering why `componentWillUnmount` is not called, when: - I'm doing `Quit` - Closing main window Is it by design? I've pasted console.log in these methods. `componentDidMount` is working fine. ``` Win10 Node v10.12.0 `-- proton-native@1.1.10 `-- libui-node@0.2.1 ```

gitea-mirror closed this issue

2026-05-05 11:46:14 -06:00

gitea-mirror commented

2026-05-05 11:46:16 -06:00

Author

Owner

@kusti8 commented on GitHub (Feb 1, 2019):

When the main window is closed, then the libui loop is immediately stopped and as a result everything stops. There are callbacks, such as onShouldQuit for menu and onClose for window close. These should do the same things and be more clear than componentWillUnmount.

@kusti8 commented on GitHub (Feb 1, 2019): When the main window is closed, then the libui loop is immediately stopped and as a result everything stops. There are callbacks, such as [onShouldQuit](https://proton-native.js.org/#/component_APIs/app?id=onshouldquit) for menu and [onClose](https://proton-native.js.org/#/component_APIs/window?id=onclose) for window close. These should do the same things and be more clear than componentWillUnmount.

gitea-mirror commented

2026-05-05 11:46:18 -06:00

Author

Owner

@kusti8 commented on GitHub (Jan 19, 2020):

Proton Native V2 is now released! If the issue still occurs in the new update, please open a new issue.

@kusti8 commented on GitHub (Jan 19, 2020): Proton Native V2 is now released! If the issue still occurs in the new update, please open a new issue.

gitea-mirror referenced this issue

2026-05-05 11:57:27 -06:00

[PR #124] [MERGED] Small typo in about.md #266