mirror of
https://github.com/kusti8/proton-native.git
synced 2026-05-15 14:15:50 -06:00
[GH-ISSUE #13] Menu and Menu items not showing up on Mac OS. #12
Labels
No labels
bug
documentation
enhancement
libui issue
pull-request
question
wait for libui implementation
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/proton-native#12
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @soorajvnair on GitHub (Feb 17, 2018).
Original GitHub issue: https://github.com/kusti8/proton-native/issues/13
Hey there, Wohoo! Finally an alternative to electron, great job! I ran the example code and the note editor showed up just fine. However the menu is missing. See the attached screenshot.
My OS is Mac OS High Sierra 10.13.3
@RemyRylan commented on GitHub (Feb 17, 2018):
Experiencing this as well on macOS 10.13.4 Beta.
@magicpriest commented on GitHub (Feb 19, 2018):
Same issue with OS X 10.13 (17A365).
@kusti8 commented on GitHub (Feb 19, 2018):
Seems like it's a bug in libui/libui-node. I'll look at it, but I may not have that much time.
@magicpriest commented on GitHub (Feb 19, 2018):
@kusti8
Yeah sure, this bug related to libui-node.
I suppose its related to Sierra error which mentioned here, somehow core library examples cannot be run in main thread. I'll debug further on weekend, but already fall in love with your work! Thank you!
@parro-it commented on GitHub (Feb 19, 2018):
Hi, libui-node author here.
I wrote some comment on the issue you mention.
Antway, I think the menu problerm is unrelated to that, but could depend on this issue of libui: https://github.com/andlabs/libui/issues/152
@parro-it commented on GitHub (Feb 19, 2018):
See also https://github.com/parro-it/libui-node/issues/52
@andlabs commented on GitHub (Feb 19, 2018):
Are you using a version of libui that has a call to
[realNSApp() finishLaunching];indarwin/main.m'suiMainSteps()? If not, that's the likely issue.@parro-it commented on GitHub (Feb 19, 2018):
It's using the last version of my libui fork
@parro-it commented on GitHub (Feb 19, 2018):
But it doesn't seem to have any such call:
f9f91a80dd/darwin/main.m (L162)@soorajvnair commented on GitHub (Feb 20, 2018):
Thanks for taking time out to look into this @parro-it, @andlabs .
@magicpriest commented on GitHub (Feb 20, 2018):
@parro-it
Thank you for explanation.
@kusti8 commented on GitHub (Mar 22, 2018):
Should be fixed in the latest version.
@soorajvnair commented on GitHub (Mar 24, 2018):
Awesome. Thanks for the update @kusti8