github-starred/proton-native
2
0
Fork 0
mirror of https://github.com/kusti8/proton-native.git synced 2026-05-15 14:15:50 -06:00
Code Issues 88 Projects Packages Wiki Activity Actions

Existence guard containerProps.children (#257)

Browse source 
Prevents a `Cannot read property 'children' of undefined` error if using an element not yet defined, therefore allows the `Element is not defined` error to actually throw.
This commit is contained in:
Alex Rosario 2020-01-30 12:36:36 -05:00 • committed by GitHub
parent 125869ce79
commit 0722b3c2c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/components/Root.ts
View file

@ -24,18 +24,22 @@ export default (props: {}) => {
);
const quit = () => {
for (let i = 0; i < containerProps.children[0].children.length; i++) {
containerProps.children[0].children[i].element.close();
if (containerProps.children && containerProps.children.length) {
for (let i = 0; i < containerProps.children[0].children.length; i++) {
containerProps.children[0].children[i].element.close();
}
}
disconnectDevtools();
};
const interval = setInterval(() => {
for (let i = 0; i < containerProps.children[0].children.length; i++) {
const closed = containerProps.children[0].children[i].element.getClosed();
if (!closed) {
element.runLoop();
return;
if (containerProps.children && containerProps.children.length) {
for (let i = 0; i < containerProps.children[0].children.length; i++) {
const closed = containerProps.children[0].children[i].element.getClosed();
if (!closed) {
element.runLoop();
return;
}
}
}
quit();