[PR #176] [MERGED] fix(api/device): fix device.pcie_tx_throughput() returns PCIe RX throughput due to a typo in argument #187

Closed
opened 2026-05-05 03:27:28 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/XuehaiPan/nvitop/pull/176
Author: @1saac-k
Created: 8/6/2025
Status: Merged
Merged: 8/6/2025
Merged by: @XuehaiPan

Base: mainHead: fix_pcie_tx_throughput


📝 Commits (1)

  • f1df31e fix(api/device): fix typo that retrieves RX instead of TX in pcie_tx_throughput()

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 nvitop/api/device.py (+1 -1)

📄 Description

Issue Type

  • Bug fix

Runtime Environment

..

Description

Trivial typo fix. The pcie_tx_throughput() function was reading the RX value instead of the TX value.

Motivation and Context

Problem: Unable to collect PCIe Tx metrics.

Testing

I manually tested it. Given that it's a minor correction, I won't include it in the log, but I can add it if required.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/XuehaiPan/nvitop/pull/176 **Author:** [@1saac-k](https://github.com/1saac-k) **Created:** 8/6/2025 **Status:** ✅ Merged **Merged:** 8/6/2025 **Merged by:** [@XuehaiPan](https://github.com/XuehaiPan) **Base:** `main` ← **Head:** `fix_pcie_tx_throughput` --- ### 📝 Commits (1) - [`f1df31e`](https://github.com/XuehaiPan/nvitop/commit/f1df31efff4e0284268b975e248cd01ee5f301f7) fix(api/device): fix typo that retrieves RX instead of TX in pcie_tx_throughput() ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `nvitop/api/device.py` (+1 -1) </details> ### 📄 Description #### Issue Type - Bug fix #### Runtime Environment .. #### Description Trivial typo fix. The pcie_tx_throughput() function was reading the RX value instead of the TX value. #### Motivation and Context Problem: Unable to collect PCIe Tx metrics. #### Testing I manually tested it. Given that it's a minor correction, I won't include it in the log, but I can add it if required. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:27:28 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/nvitop#187
No description provided.