[PR #164] [MERGED] lint(tui): add doctests and add type annotations in `nvitop.tui` #182

New issue

Closed

opened 2026-05-05 03:27:22 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:27:22 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/XuehaiPan/nvitop/pull/164
Author: @XuehaiPan
Created: 4/20/2025
Status: ✅ Merged
Merged: 4/24/2025
Merged by: @XuehaiPan

Base: main ← Head: tui-typing

📝 Commits (10+)

78ed468 chore(tui): add __all__ to subpackages in nvitop.tui
c05dc2c style(tui): rename boolean constants
0057872 lint(tui): add type annotations in nvitop.tui
d9db936 lint(tui): add doctests
4635d6d fix: fix sort order keybinding
1d14f9c lint: update type annotations for snapshots
d2c18e8 lint: update annotations
37834c9 chore: simplify dict comp
4d33eaa docs(CHANGELOG): update CHANGELOG.md
0ef40da chore: minor improvements

📊 Changes

48 files changed (+2313 additions, -1516 deletions)

View changed files

📝 .github/workflows/lint.yaml (+8 -1)
📝 CHANGELOG.md (+1 -0)
📝 docs/source/spelling_wordlist.txt (+2 -0)
📝 nvitop/api/__init__.py (+1 -1)
📝 nvitop/api/collector.py (+1 -1)
📝 nvitop/api/device.py (+14 -21)
📝 nvitop/api/host.py (+4 -4)
📝 nvitop/api/libcuda.py (+2 -2)
📝 nvitop/api/libcudart.py (+3 -3)
📝 nvitop/api/libnvml.py (+5 -5)
📝 nvitop/api/process.py (+2 -2)
📝 nvitop/api/termcolor.py (+1 -2)
📝 nvitop/api/utils.py (+63 -23)
📝 nvitop/callbacks/keras.py (+2 -0)
📝 nvitop/callbacks/lightning.py (+2 -0)
📝 nvitop/callbacks/pytorch_lightning.py (+2 -0)
📝 nvitop/callbacks/tensorboard.py (+2 -0)
📝 nvitop/cli.py (+7 -7)
📝 nvitop/select.py (+5 -6)
📝 nvitop/tui/__init__.py (+13 -1)

...and 28 more files

📄 Description

Issue Type

Improvement/feature implementation

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/XuehaiPan/nvitop/pull/164 **Author:** [@XuehaiPan](https://github.com/XuehaiPan) **Created:** 4/20/2025 **Status:** ✅ Merged **Merged:** 4/24/2025 **Merged by:** [@XuehaiPan](https://github.com/XuehaiPan) **Base:** `main` ← **Head:** `tui-typing` --- ### 📝 Commits (10+) - [`78ed468`](https://github.com/XuehaiPan/nvitop/commit/78ed4681649d5e4dc76e19369d6bdd7d38cc6882) chore(tui): add `__all__` to subpackages in `nvitop.tui` - [`c05dc2c`](https://github.com/XuehaiPan/nvitop/commit/c05dc2c4946e41c4235c55fdb5f4e56a7d1eb824) style(tui): rename boolean constants - [`0057872`](https://github.com/XuehaiPan/nvitop/commit/0057872448ef9d27acd4d27d18940e5858644030) lint(tui): add type annotations in `nvitop.tui` - [`d9db936`](https://github.com/XuehaiPan/nvitop/commit/d9db936db0e4ba34e811672109ef52f7b21f4d0e) lint(tui): add doctests - [`4635d6d`](https://github.com/XuehaiPan/nvitop/commit/4635d6d392c49e2feb3de18883e873bc41be3fcd) fix: fix sort order keybinding - [`1d14f9c`](https://github.com/XuehaiPan/nvitop/commit/1d14f9ca16fe7e8d1367b1f71188f0206e05ea98) lint: update type annotations for snapshots - [`d2c18e8`](https://github.com/XuehaiPan/nvitop/commit/d2c18e86b046798f32b7c847c5ec7e233e26bdd9) lint: update annotations - [`37834c9`](https://github.com/XuehaiPan/nvitop/commit/37834c99f57a9f2f33f8dac7cdd1f41b8018163f) chore: simplify dict comp - [`4d33eaa`](https://github.com/XuehaiPan/nvitop/commit/4d33eaacbcd4ae2ba1af24fbbed8fbd07f9dd9db) docs(CHANGELOG): update CHANGELOG.md - [`0ef40da`](https://github.com/XuehaiPan/nvitop/commit/0ef40da7dd48a16c13fbf64a584754e77b85d0ea) chore: minor improvements ### 📊 Changes **48 files changed** (+2313 additions, -1516 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/lint.yaml` (+8 -1) 📝 `CHANGELOG.md` (+1 -0) 📝 `docs/source/spelling_wordlist.txt` (+2 -0) 📝 `nvitop/api/__init__.py` (+1 -1) 📝 `nvitop/api/collector.py` (+1 -1) 📝 `nvitop/api/device.py` (+14 -21) 📝 `nvitop/api/host.py` (+4 -4) 📝 `nvitop/api/libcuda.py` (+2 -2) 📝 `nvitop/api/libcudart.py` (+3 -3) 📝 `nvitop/api/libnvml.py` (+5 -5) 📝 `nvitop/api/process.py` (+2 -2) 📝 `nvitop/api/termcolor.py` (+1 -2) 📝 `nvitop/api/utils.py` (+63 -23) 📝 `nvitop/callbacks/keras.py` (+2 -0) 📝 `nvitop/callbacks/lightning.py` (+2 -0) 📝 `nvitop/callbacks/pytorch_lightning.py` (+2 -0) 📝 `nvitop/callbacks/tensorboard.py` (+2 -0) 📝 `nvitop/cli.py` (+7 -7) 📝 `nvitop/select.py` (+5 -6) 📝 `nvitop/tui/__init__.py` (+13 -1) _...and 28 more files_ </details> ### 📄 Description  #### Issue Type  - Improvement/feature implementation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>