[PR #73] [MERGED] feat(linter): `mypy` integration #149

New issue

Closed

opened 2026-05-05 03:26:46 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:26:46 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/XuehaiPan/nvitop/pull/73
Author: @XuehaiPan
Created: 4/30/2023
Status: ✅ Merged
Merged: 5/1/2023
Merged by: @XuehaiPan

Base: main ← Head: mypy

📝 Commits (5)

4bb3da7 feat(linter): mypy integration
afd9ba2 docs: add notes to set CUDA_DEVICE_ORDER="PCI_BUS_ID"
6697d54 docs(CHANGELOG): update CHANGELOG.md
c730af2 chore(api/device): update type annotations
00ab574 chore(api): update type annotations

📊 Changes

22 files changed (+640 additions, -355 deletions)

View changed files

📝 .flake8 (+1 -0)
📝 .github/workflows/build.yaml (+1 -1)
📝 .github/workflows/lint.yaml (+1 -1)
📝 .pre-commit-config.yaml (+13 -5)
📝 CHANGELOG.md (+2 -2)
📝 README.md (+3 -0)
📝 docs/source/spelling_wordlist.txt (+1 -0)
📝 nvitop/api/collector.py (+76 -65)
📝 nvitop/api/device.py (+134 -83)
📝 nvitop/api/host.py (+12 -4)
📝 nvitop/api/libcuda.py (+41 -18)
📝 nvitop/api/libcudart.py (+29 -9)
📝 nvitop/api/libnvml.py (+80 -42)
📝 nvitop/api/process.py (+33 -18)
📝 nvitop/api/utils.py (+50 -33)
📝 nvitop/callbacks/keras.py (+1 -2)
📝 nvitop/callbacks/pytorch_lightning.py (+1 -2)
📝 nvitop/cli.py (+25 -18)
📝 nvitop/gui/library/device.py (+2 -2)
📝 nvitop/select.py (+106 -49)

...and 2 more files

📄 Description

Issue Type

Improvement/feature implementation

Description

Add mypy integration and update type annotations for nvitop.api.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/XuehaiPan/nvitop/pull/73 **Author:** [@XuehaiPan](https://github.com/XuehaiPan) **Created:** 4/30/2023 **Status:** ✅ Merged **Merged:** 5/1/2023 **Merged by:** [@XuehaiPan](https://github.com/XuehaiPan) **Base:** `main` ← **Head:** `mypy` --- ### 📝 Commits (5) - [`4bb3da7`](https://github.com/XuehaiPan/nvitop/commit/4bb3da75f3d75ae863546d89d0d87daa6be983b9) feat(linter): `mypy` integration - [`afd9ba2`](https://github.com/XuehaiPan/nvitop/commit/afd9ba2514c58657c096d02cf21e2b9bc685ba94) docs: add notes to set `CUDA_DEVICE_ORDER="PCI_BUS_ID"` - [`6697d54`](https://github.com/XuehaiPan/nvitop/commit/6697d54895f6dd8cc6d627345f02f41577ec1cdd) docs(CHANGELOG): update CHANGELOG.md - [`c730af2`](https://github.com/XuehaiPan/nvitop/commit/c730af21068fb71e25dd35c0d0b9d2dc286ac1f6) chore(api/device): update type annotations - [`00ab574`](https://github.com/XuehaiPan/nvitop/commit/00ab574e8582eb00bd01e3738cdd8e6fdcec6970) chore(api): update type annotations ### 📊 Changes **22 files changed** (+640 additions, -355 deletions) <details> <summary>View changed files</summary> 📝 `.flake8` (+1 -0) 📝 `.github/workflows/build.yaml` (+1 -1) 📝 `.github/workflows/lint.yaml` (+1 -1) 📝 `.pre-commit-config.yaml` (+13 -5) 📝 `CHANGELOG.md` (+2 -2) 📝 `README.md` (+3 -0) 📝 `docs/source/spelling_wordlist.txt` (+1 -0) 📝 `nvitop/api/collector.py` (+76 -65) 📝 `nvitop/api/device.py` (+134 -83) 📝 `nvitop/api/host.py` (+12 -4) 📝 `nvitop/api/libcuda.py` (+41 -18) 📝 `nvitop/api/libcudart.py` (+29 -9) 📝 `nvitop/api/libnvml.py` (+80 -42) 📝 `nvitop/api/process.py` (+33 -18) 📝 `nvitop/api/utils.py` (+50 -33) 📝 `nvitop/callbacks/keras.py` (+1 -2) 📝 `nvitop/callbacks/pytorch_lightning.py` (+1 -2) 📝 `nvitop/cli.py` (+25 -18) 📝 `nvitop/gui/library/device.py` (+2 -2) 📝 `nvitop/select.py` (+106 -49) _...and 2 more files_ </details> ### 📄 Description  #### Issue Type  - Improvement/feature implementation #### Description  Add `mypy` integration and update type annotations for `nvitop.api`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>