mirror of
https://github.com/XuehaiPan/nvitop.git
synced 2026-05-15 14:15:55 -06:00
[PR #66] [MERGED] refactor(api): move TTLCache usage to CLI-only #146
Labels
No labels
api
bug
bug
cli / tui
dependencies
documentation
documentation
documentation
duplicate
enhancement
exporter
invalid
pull-request
pynvml
question
question
upstream
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/nvitop#146
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/XuehaiPan/nvitop/pull/66
Author: @XuehaiPan
Created: 4/7/2023
Status: ✅ Merged
Merged: 4/7/2023
Merged by: @XuehaiPan
Base:
main← Head:move-ttl-cache📝 Commits (3)
ac56c6arefactor(api): moveTTLCacheusage to CLI-onlydbc2f65docs(CHANGELOG): update CHANGELOG.md7b54f40feat(workflows): add import tests for Python 3.7📊 Changes
6 files changed (+38 additions, -50 deletions)
View changed files
📝
.github/workflows/lint.yaml(+10 -0)📝
CHANGELOG.md(+1 -1)📝
nvitop/api/device.py(+2 -25)📝
nvitop/api/host.py(+10 -10)📝
nvitop/api/process.py(+0 -1)📝
nvitop/gui/library/device.py(+15 -13)📄 Description
Issue Type
Description
Move
TTLCacheusage to CLI-only. Public APIs innvitop.apiwill always return immediate results.Motivation and Context
In the previous implementation, the public APIs may return cached results. Now all caching mechanisms are moved to CLI-only. This is more consistent with other packages such as
psutil.Process.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.