[PR #51] [MERGED] fix(Dockerfile): migrate docker image repo to nvcr.io/nvidia/driver #136

Closed
opened 2026-05-05 03:26:34 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/XuehaiPan/nvitop/pull/51
Author: @XuehaiPan
Created: 12/13/2022
Status: Merged
Merged: 12/13/2022
Merged by: @XuehaiPan

Base: mainHead: fix-dockerfile


📝 Commits (3)

  • 72646ed fix(Dockerfile): migrate docker image repo to nvcr.io/nvidia/driver
  • 1f602e3 test(.github): test Dockerfile in GitHub Actions
  • 7a59729 fix(Dockerfile): downgrade the default docker base tag

📊 Changes

3 files changed (+22 additions, -7 deletions)

View changed files

📝 .github/workflows/build.yaml (+6 -0)
📝 Dockerfile (+15 -6)
📝 README.md (+1 -1)

📄 Description

Issue Type

  • Bug fix
  • Improvement/feature implementation

Runtime Environment

  • Operating system and version: Ubuntu 20.04 LTS
  • Terminal emulator and version: GNOME Terminal 3.36.2
  • Python version: 3.10.8
  • NVML version (driver version): 525.60.11
  • nvitop version or commit: main@c04fbb
  • python-ml-py version: 11.515.75
  • Locale: en_US.UTF-8

Description

  • Migrate the docker image repo to nvcr.io/nvidia/driver. The old repo on Docker Hub is out of maintenance.
  • Add minimal test for the Dockerfile in GitHub Actions.

Motivation and Context

Python 3.6 is end-of-life and the highest supported setuptools does not support pyprocject.toml based projects. It cannot install the dependencies correctly. This PR replaces the requirements.txt approach in #50 and updates the docker image.

Closes #50

Testing

N/A

Images / Videos

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/XuehaiPan/nvitop/pull/51 **Author:** [@XuehaiPan](https://github.com/XuehaiPan) **Created:** 12/13/2022 **Status:** ✅ Merged **Merged:** 12/13/2022 **Merged by:** [@XuehaiPan](https://github.com/XuehaiPan) **Base:** `main` ← **Head:** `fix-dockerfile` --- ### 📝 Commits (3) - [`72646ed`](https://github.com/XuehaiPan/nvitop/commit/72646edd45decb92264a1463292525562a1d3365) fix(Dockerfile): migrate docker image repo to nvcr.io/nvidia/driver - [`1f602e3`](https://github.com/XuehaiPan/nvitop/commit/1f602e36e576b13837121a076625da163daadb49) test(.github): test `Dockerfile` in GitHub Actions - [`7a59729`](https://github.com/XuehaiPan/nvitop/commit/7a59729e81e7d089586ed0c9917f98e69cb24496) fix(Dockerfile): downgrade the default docker base tag ### 📊 Changes **3 files changed** (+22 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yaml` (+6 -0) 📝 `Dockerfile` (+15 -6) 📝 `README.md` (+1 -1) </details> ### 📄 Description <!-- Provide a descriptive summary of the changes in the title above --> #### Issue Type <!-- Pick relevant types and delete the rest --> - Bug fix - Improvement/feature implementation #### Runtime Environment <!-- Details of your runtime environment --> - Operating system and version: Ubuntu 20.04 LTS - Terminal emulator and version: GNOME Terminal 3.36.2 - Python version: `3.10.8` - NVML version (driver version): `525.60.11` - `nvitop` version or commit: `main@c04fbb` - `python-ml-py` version: `11.515.75` - Locale: `en_US.UTF-8` #### Description <!-- Describe the changes in detail --> - Migrate the docker image repo to [nvcr.io/nvidia/driver](https://catalog.ngc.nvidia.com/orgs/nvidia/containers/driver). The old repo on [Docker Hub](https://hub.docker.com/r/nvidia/driver) is out of maintenance. - Add minimal test for the `Dockerfile` in GitHub Actions. #### Motivation and Context <!-- Why are these changes required? --> <!-- What problems do these changes solve? --> <!-- Link to relevant issues --> Python 3.6 is end-of-life and the highest supported `setuptools` does not support `pyprocject.toml` based projects. It cannot install the dependencies correctly. This PR replaces the `requirements.txt` approach in #50 and updates the docker image. Closes #50 #### Testing <!-- What tests have been run? --> <!-- How does the changes affect other areas of the codebase? --> N/A #### Images / Videos <!-- Only if relevant --> <!-- Link or embed images and videos of screenshots, sketches etc. --> <img width="1385" alt="image" src="https://user-images.githubusercontent.com/16078332/207275341-92e5198e-b51a-44c6-a7f0-1de80013bf5c.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 03:26:34 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/nvitop#136
No description provided.