[PR #42] [MERGED] feat(gui/messagebox): add message box #133

New issue

Closed

opened 2026-05-05 03:26:28 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:26:28 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/XuehaiPan/nvitop/pull/42
Author: @XuehaiPan
Created: 10/4/2022
Status: ✅ Merged
Merged: 10/6/2022
Merged by: @XuehaiPan

Base: main ← Head: messagebox

📝 Commits (10+)

bc34725 refactor(gui): rename class name and variables
671033f refactor(gui): refactor keymaps
e149123 feat(gui/messagebox): add message box
c320807 chore(gui/messagebox): update keybindings
f9c9412 chore(gui/messagebox): handle numbered curses attributes
207d163 feat(gui/messagebox): add mouse click support
a7571df feat(gui/messagebox): better mouse click support
11eecfb feat(gui/messagebox): add number keys
051e8a9 feat(gui/messagebox): improve keybindings
2f9ea0e chore(gui/metrics): update y ticks

📊 Changes

13 files changed (+557 additions, -138 deletions)

View changed files

📝 .pylintrc (+2 -1)
📝 nvitop/cli.py (+9 -9)
📝 nvitop/gui/__init__.py (+1 -1)
📝 nvitop/gui/library/__init__.py (+2 -0)
📝 nvitop/gui/library/keybinding.py (+25 -1)
➕ nvitop/gui/library/messagebox.py (+327 -0)
📝 nvitop/gui/library/selection.py (+8 -8)
📝 nvitop/gui/library/widestring.py (+46 -0)
📝 nvitop/gui/screens/environ.py (+24 -22)
📝 nvitop/gui/screens/main/__init__.py (+52 -58)
📝 nvitop/gui/screens/metrics.py (+1 -1)
📝 nvitop/gui/screens/treeview.py (+29 -34)
📝 nvitop/gui/ui.py (+31 -3)

📄 Description

Issue Type

Improvement/feature implementation

Runtime Environment

Operating system and version: Ubuntu 20.04 LTS
Terminal emulator and version: GNOME Terminal 3.36.2
Python version: e.g. 3.10.7
NVML version (driver version): 470.141.03
nvitop version or commit: 0.8.2.dev7+g09d8774
python-ml-py version: 11.450.51
Locale: en_US.UTF-8

Description

Add confirm message box before sending signals to processes.

Motivation and Context

Resolves #40

Testing

N/A

Images / Videos

https://user-images.githubusercontent.com/16078332/193865188-821816ac-328d-408e-9d2a-7c8c1ebef350.mov

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/XuehaiPan/nvitop/pull/42 **Author:** [@XuehaiPan](https://github.com/XuehaiPan) **Created:** 10/4/2022 **Status:** ✅ Merged **Merged:** 10/6/2022 **Merged by:** [@XuehaiPan](https://github.com/XuehaiPan) **Base:** `main` ← **Head:** `messagebox` --- ### 📝 Commits (10+) - [`bc34725`](https://github.com/XuehaiPan/nvitop/commit/bc34725e068da797d94b18fa8cacc8a47b46355c) refactor(gui): rename class name and variables - [`671033f`](https://github.com/XuehaiPan/nvitop/commit/671033fce8a94a034a2785f463e7303bb7cec7c5) refactor(gui): refactor keymaps - [`e149123`](https://github.com/XuehaiPan/nvitop/commit/e1491234be45d71a12b151f6e17012f155937718) feat(gui/messagebox): add message box - [`c320807`](https://github.com/XuehaiPan/nvitop/commit/c3208072cdbcf6afd37cb26febbe4ffa09a0a361) chore(gui/messagebox): update keybindings - [`f9c9412`](https://github.com/XuehaiPan/nvitop/commit/f9c9412618f611097c1122f959ed64dff984a5ba) chore(gui/messagebox): handle numbered curses attributes - [`207d163`](https://github.com/XuehaiPan/nvitop/commit/207d163fecd44d2465d4cd49d74ea0bac9a46915) feat(gui/messagebox): add mouse click support - [`a7571df`](https://github.com/XuehaiPan/nvitop/commit/a7571dfbb3e4e05b47beb623b6156aa36805d5b1) feat(gui/messagebox): better mouse click support - [`11eecfb`](https://github.com/XuehaiPan/nvitop/commit/11eecfbe7d539771285c68f90be2069f8f93e6a9) feat(gui/messagebox): add number keys - [`051e8a9`](https://github.com/XuehaiPan/nvitop/commit/051e8a964adca09aae34cb539156a056c946e969) feat(gui/messagebox): improve keybindings - [`2f9ea0e`](https://github.com/XuehaiPan/nvitop/commit/2f9ea0e235d94b81e645fbc08e407d6d1dbdb6f9) chore(gui/metrics): update y ticks ### 📊 Changes **13 files changed** (+557 additions, -138 deletions) <details> <summary>View changed files</summary> 📝 `.pylintrc` (+2 -1) 📝 `nvitop/cli.py` (+9 -9) 📝 `nvitop/gui/__init__.py` (+1 -1) 📝 `nvitop/gui/library/__init__.py` (+2 -0) 📝 `nvitop/gui/library/keybinding.py` (+25 -1) ➕ `nvitop/gui/library/messagebox.py` (+327 -0) 📝 `nvitop/gui/library/selection.py` (+8 -8) 📝 `nvitop/gui/library/widestring.py` (+46 -0) 📝 `nvitop/gui/screens/environ.py` (+24 -22) 📝 `nvitop/gui/screens/main/__init__.py` (+52 -58) 📝 `nvitop/gui/screens/metrics.py` (+1 -1) 📝 `nvitop/gui/screens/treeview.py` (+29 -34) 📝 `nvitop/gui/ui.py` (+31 -3) </details> ### 📄 Description #### Issue Type  - Improvement/feature implementation #### Runtime Environment  - Operating system and version: Ubuntu 20.04 LTS - Terminal emulator and version: GNOME Terminal 3.36.2 - Python version: e.g. `3.10.7` - NVML version (driver version): `470.141.03` - `nvitop` version or commit: `0.8.2.dev7+g09d8774` - `python-ml-py` version: `11.450.51` - Locale: `en_US.UTF-8` #### Description  Add confirm message box before sending signals to processes. #### Motivation and Context    Resolves #40 #### Testing   N/A #### Images / Videos   https://user-images.githubusercontent.com/16078332/193865188-821816ac-328d-408e-9d2a-7c8c1ebef350.mov --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>