[PR #27] [MERGED] feat(pyproject): migrate to pyproject.toml for packaging #126

New issue

Closed

opened 2026-05-05 03:26:22 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 03:26:22 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/XuehaiPan/nvitop/pull/27
Author: @XuehaiPan
Created: 7/18/2022
Status: ✅ Merged
Merged: 7/18/2022
Merged by: @XuehaiPan

Base: main ← Head: packaging

📝 Commits (5)

88510c6 style(core): resolve pylint warnings
fd7edda feat(pyproject): migrate to pyproject.toml for packaging
c80d4c8 style: format with black
497fc70 feat(pre-commit): add pre-commit hooks
ec17855 feat(workflow): run linters in GitHub Actions

📊 Changes

39 files changed (+1970 additions, -971 deletions)

View changed files

➕ .github/workflows/lint.yaml (+56 -0)
➕ .pre-commit-config.yaml (+29 -0)
📝 README.md (+4 -4)
📝 docs/source/conf.py (+5 -8)
📝 nvitop/callbacks/keras.py (+18 -10)
📝 nvitop/callbacks/pytorch_lightning.py (+23 -13)
📝 nvitop/callbacks/tensorboard.py (+3 -3)
📝 nvitop/callbacks/utils.py (+9 -7)
📝 nvitop/cli.py (+210 -82)
📝 nvitop/core/__init__.py (+20 -8)
📝 nvitop/core/collector.py (+42 -41)
📝 nvitop/core/device.py (+261 -139)
📝 nvitop/core/host.py (+12 -5)
📝 nvitop/core/libnvml.py (+96 -69)
📝 nvitop/core/process.py (+108 -78)
📝 nvitop/core/utils.py (+19 -9)
📝 nvitop/gui/__init__.py (+9 -2)
📝 nvitop/gui/library/__init__.py (+24 -8)
📝 nvitop/gui/library/device.py (+70 -45)
📝 nvitop/gui/library/history.py (+56 -20)

...and 19 more files

📄 Description

Issue Type

Improvement/feature implementation

Runtime Environment

Operating system and version: Ubuntu 20.04 LTS
Terminal emulator and version: GNOME Terminal 3.36.2
Python version: 3.9.13
NVML version (driver version): 470.129.06
nvitop version or commit: main@0a9048
python-ml-py version: 11.450.51
Locale: en_US.UTF-8

Description

migrate to pyproject.toml for packaging PEP 518
format code with black
add pre-commit hooks

Motivation and Context

Improve code quality.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/XuehaiPan/nvitop/pull/27 **Author:** [@XuehaiPan](https://github.com/XuehaiPan) **Created:** 7/18/2022 **Status:** ✅ Merged **Merged:** 7/18/2022 **Merged by:** [@XuehaiPan](https://github.com/XuehaiPan) **Base:** `main` ← **Head:** `packaging` --- ### 📝 Commits (5) - [`88510c6`](https://github.com/XuehaiPan/nvitop/commit/88510c6038c8bf58685049184bd7888c122e92a8) style(core): resolve pylint warnings - [`fd7edda`](https://github.com/XuehaiPan/nvitop/commit/fd7edda30a4151e69e97e4a9cf495af87c9a87d5) feat(pyproject): migrate to pyproject.toml for packaging - [`c80d4c8`](https://github.com/XuehaiPan/nvitop/commit/c80d4c8e96abed1ae27bb33044e722bc2963e1f6) style: format with black - [`497fc70`](https://github.com/XuehaiPan/nvitop/commit/497fc707a70311a2af7558bc8053d0dca4e3a984) feat(pre-commit): add pre-commit hooks - [`ec17855`](https://github.com/XuehaiPan/nvitop/commit/ec17855b1e74b751c384f1c9eb0fd44ada39c450) feat(workflow): run linters in GitHub Actions ### 📊 Changes **39 files changed** (+1970 additions, -971 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/lint.yaml` (+56 -0) ➕ `.pre-commit-config.yaml` (+29 -0) 📝 `README.md` (+4 -4) 📝 `docs/source/conf.py` (+5 -8) 📝 `nvitop/callbacks/keras.py` (+18 -10) 📝 `nvitop/callbacks/pytorch_lightning.py` (+23 -13) 📝 `nvitop/callbacks/tensorboard.py` (+3 -3) 📝 `nvitop/callbacks/utils.py` (+9 -7) 📝 `nvitop/cli.py` (+210 -82) 📝 `nvitop/core/__init__.py` (+20 -8) 📝 `nvitop/core/collector.py` (+42 -41) 📝 `nvitop/core/device.py` (+261 -139) 📝 `nvitop/core/host.py` (+12 -5) 📝 `nvitop/core/libnvml.py` (+96 -69) 📝 `nvitop/core/process.py` (+108 -78) 📝 `nvitop/core/utils.py` (+19 -9) 📝 `nvitop/gui/__init__.py` (+9 -2) 📝 `nvitop/gui/library/__init__.py` (+24 -8) 📝 `nvitop/gui/library/device.py` (+70 -45) 📝 `nvitop/gui/library/history.py` (+56 -20) _...and 19 more files_ </details> ### 📄 Description #### Issue Type  - Improvement/feature implementation #### Runtime Environment  - Operating system and version: Ubuntu 20.04 LTS - Terminal emulator and version: GNOME Terminal 3.36.2 - Python version: `3.9.13` - NVML version (driver version): `470.129.06` - `nvitop` version or commit: `main@0a9048` - `python-ml-py` version: `11.450.51` - Locale: `en_US.UTF-8` #### Description  - migrate to `pyproject.toml` for packaging [PEP 518](https://peps.python.org/pep-0518/) - format code with [`black`](https://github.com/psf/black) - add [`pre-commit`](https://pre-commit.com/) hooks #### Motivation and Context    Improve code quality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>