github-starred/libxlsxwriter

Fork 0

mirror of https://github.com/jmcnamara/libxlsxwriter.git synced 2026-05-15 14:15:54 -06:00

[GH-ISSUE #119] Use system minizip when possible #99

New issue

Closed

opened 2026-05-05 11:40:07 -06:00 by gitea-mirror · 13 comments

gitea-mirror commented

2026-05-05 11:40:07 -06:00

Owner

Originally created by @ohmyarch on GitHub (Aug 12, 2017).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/119

Originally assigned to: @jmcnamara on GitHub.

When system-wide installed minizip can be found, use it instead of bundled one.

Originally created by @ohmyarch on GitHub (Aug 12, 2017). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/119 Originally assigned to: @jmcnamara on GitHub. When system-wide installed minizip can be found, use it instead of bundled one.

gitea-mirror

2026-05-05 11:40:07 -06:00

closed this issue
added the
feature request

short term

cmake
labels

gitea-mirror commented

2026-05-05 11:40:14 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 12, 2017):

Why do you want this feature?

@jmcnamara commented on GitHub (Aug 12, 2017): Why do you want this feature?

gitea-mirror commented

2026-05-05 11:40:16 -06:00

Author

Owner

@ohmyarch commented on GitHub (Aug 12, 2017):

Why do you use system zlib?

@ohmyarch commented on GitHub (Aug 12, 2017): Why do you use system zlib?

gitea-mirror commented

2026-05-05 11:40:19 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 12, 2017):

Because zlib is very common and available almost everywhere. Minizip isn't.

@jmcnamara commented on GitHub (Aug 12, 2017): Because zlib is very common and available almost everywhere. Minizip isn't.

gitea-mirror commented

2026-05-05 11:40:21 -06:00

Author

Owner

@ohmyarch commented on GitHub (Aug 12, 2017):

I don't think so. Minizip is also a common package and can be installed via a single command in many cases, for example:

 pacman -S minizip

brew install minizip

I am not asking you to remove the bundled version. I just think that it's usually better to use the system library. Using system (shared) libraries can save disk space and memory. Besides, system libraries can be always up-to-date in some rolling release distro.

If you think it's unnecessary, just close this issue.

@ohmyarch commented on GitHub (Aug 12, 2017): I don't think so. Minizip is also a common package and can be installed via a single command in many cases, for example: ```zsh pacman -S minizip ``` ```zsh brew install minizip ``` I am not asking you to remove the bundled version. I just think that it's usually better to use the system library. Using system (shared) libraries can save disk space and memory. Besides, system libraries can be always up-to-date in some rolling release distro. If you think it's unnecessary, just close this issue.

gitea-mirror commented

2026-05-05 11:40:23 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 12, 2017):

Thanks for the explanation. When I started this project 3 years ago I didn't see many packaged versions of minizip. In general I would prefer not to have to bundle it.

I'll add this feature to the Make build system. Adding it to the CMake system may take a bit longer.

@jmcnamara commented on GitHub (Aug 12, 2017): Thanks for the explanation. When I started this project 3 years ago I didn't see many packaged versions of minizip. In general I would prefer not to have to bundle it. I'll add this feature to the Make build system. Adding it to the CMake system may take a bit longer.

gitea-mirror commented

2026-05-05 11:40:24 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 14, 2017):

I've added this to the master branch for the Makefile build system. It can be invoked as follows:

USE_SYSTEM_MINIZIP=1 make

@jmcnamara commented on GitHub (Aug 14, 2017): I've added this to the master branch for the Makefile build system. It can be invoked as follows: USE_SYSTEM_MINIZIP=1 make

gitea-mirror commented

2026-05-05 11:40:26 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 14, 2017):

@Alexhuszagh When you get a chance can you look at adding support for system minizip to the CMake system as well.

@jmcnamara commented on GitHub (Aug 14, 2017): @Alexhuszagh When you get a chance can you look at adding support for system minizip to the CMake system as well.

gitea-mirror commented

2026-05-05 11:40:30 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 17, 2017):

@ohmyarch Did you get a chance to try this?

@jmcnamara commented on GitHub (Aug 17, 2017): @ohmyarch Did you get a chance to try this?

gitea-mirror commented

2026-05-05 11:40:34 -06:00

Author

Owner

@jmcnamara commented on GitHub (Oct 22, 2017):

@Alexhuszagh, this is one you could have a look at as well. However, it isn't high priority so if you don't want to add it to the CMake build that is okay.

@jmcnamara commented on GitHub (Oct 22, 2017): @Alexhuszagh, this is one you could have a look at as well. However, it isn't high priority so if you don't want to add it to the CMake build that is okay.

gitea-mirror commented

2026-05-05 11:40:37 -06:00

Author

Owner

@Alexhuszagh commented on GitHub (Oct 22, 2017):

@jmcnamara Sorry I just saw this. I should be able to get around to it early next week.

@Alexhuszagh commented on GitHub (Oct 22, 2017): @jmcnamara Sorry I just saw this. I should be able to get around to it early next week.

gitea-mirror commented

2026-05-05 11:40:39 -06:00

Author

Owner

@Alexhuszagh commented on GitHub (Oct 23, 2017):

@jmcnamara This should be patched in my downstream fork. It relies on the changes made in #131, however, if need be, I can make the changes atop the current CMakeLists. If these changes are satisfactory, I will submit a PR.

@Alexhuszagh commented on GitHub (Oct 23, 2017): @jmcnamara This should be patched in my [downstream fork](https://github.com/Alexhuszagh/libxlsxwriter/tree/minizip). It relies on the changes made in #131, however, if need be, I can make the changes atop the current CMakeLists. If these changes are satisfactory, I will submit a PR.

gitea-mirror commented

2026-05-05 11:40:41 -06:00

Author

Owner

@jmcnamara commented on GitHub (Oct 24, 2017):

@ohmyarch can you try the fix on master for this. See also #133

@jmcnamara commented on GitHub (Oct 24, 2017): @ohmyarch can you try the fix on master for this. See also #133

gitea-mirror commented

2026-05-05 11:40:43 -06:00

Author

Owner

@ohmyarch commented on GitHub (Oct 31, 2017):

ldd /usr/lib/libxlsxwriter.so

linux-vdso.so.1 (0x00007ffda713f000)
libminizip.so.1 => /usr/lib/libminizip.so.1 (0x00007f14b3212000)
libc.so.6 => /usr/lib/libc.so.6 (0x00007f14b2e5b000)
libz.so.1 => /usr/lib/libz.so.1 (0x00007f14b2c44000)
/usr/lib64/ld-linux-x86-64.so.2 (0x00007f14b365c000)

It works. 🎉👍

@ohmyarch commented on GitHub (Oct 31, 2017): <pre> ldd /usr/lib/libxlsxwriter.so linux-vdso.so.1 (0x00007ffda713f000) <b>libminizip.so.1 => /usr/lib/libminizip.so.1 (0x00007f14b3212000)</b> libc.so.6 => /usr/lib/libc.so.6 (0x00007f14b2e5b000) libz.so.1 => /usr/lib/libz.so.1 (0x00007f14b2c44000) /usr/lib64/ld-linux-x86-64.so.2 (0x00007f14b365c000) </pre> It works. 🎉👍