mirror of
https://github.com/jmcnamara/libxlsxwriter.git
synced 2026-05-15 14:15:54 -06:00
[GH-ISSUE #97] Codesigning the libxlsxwriter framework fails on macOS #83
Labels
No labels
awaiting user feedback
bug
cmake
cmake
docs
feature request
in progress
long term
medium term
medium term
pull-request
question
question
ready to close
short term
under investigation
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/libxlsxwriter#83
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MrMage on GitHub (Feb 27, 2017).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/97
When trying to depend on libxlsxwriter via CocoaPods in a macOS target, signing libxlsxwriter.framework fails with the following error message:
The problem is that the framework target is set up such that
xlsxwriter.his put into the framework's main directory, alongside thexlsxwriterbinary. It appears that thecodesignutility only expects binaries in that directory when signing Mac frameworks, though, with all headers being in theHeaderssubdirectory (otherwise it fails with anxlsxwriter.h: code object is not signed at allmessage). Signing frameworks for iOS works fine, even ifxlsxwriter.his in the framework's main directory.Here's a sample project to reproduce this issue: libxslwriterCocoaPodsExample.zip.
The issue occurs both at
HEADand with the latest published CocoaPod.https://github.com/jmcnamara/libxlsxwriter/pull/94 fixes this issue and introduces no regressions on iOS. To confirm the fix, simply change the two
https://github.com/jmcnamara/libxlsxwriterURLs in the example'sPodfiletohttps://github.com/MrMage/libxlsxwriter, runpod installand rebuild (when building for iOS, make sure to build for a device as simulator binaries are not codesigned anyway).@jmcnamara commented on GitHub (Feb 28, 2017):
@lrossi Could you have a look at this and the associated pull request. Thanks.
@lrossi commented on GitHub (Feb 28, 2017):
Yes, I'll take a look ASAP
@mdfalcon104 commented on GitHub (Sep 20, 2017):
@lrossi Got the same issue. Can you fix it?
@jmcnamara commented on GitHub (Sep 20, 2017):
@dlpigpen Does the pull request in #94 fix your issue?
@jmcnamara commented on GitHub (Oct 22, 2017):
Closed by PR #127.