[PR #511] [CLOSED] Memory safety fixes #512

New issue

Closed

opened 2026-05-05 12:17:54 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:17:54 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/511
Author: @billdenney
Created: 4/5/2026
Status: ❌ Closed

Base: main ← Head: memory-safety-fixes

📝 Commits (5)

88a44a9 worksheet: fix uint8_t counter overflow in validation list functions
eeb2d89 worksheet: fix quadratic over-allocation in _set_default_table_columns
de6aaee utility: guarantee null termination after strncpy in lxw_rowcol_to_formula_abs
da95035 utility: use size_t index and unsigned char cast in lxw_str_tolower
74e5406 Changes: document memory safety fixes for 1.2.5

📊 Changes

4 files changed (+94 additions, -6 deletions)

View changed files

📝 Changes.txt (+36 -0)
📝 src/utility.c (+3 -2)
📝 src/worksheet.c (+4 -4)
➕ test/unit/worksheet/test_worksheet_validation_list_overflow.c (+51 -0)

📄 Description

This was intended as a simple fix for some possible memory issues identified by AI. If it needs discussion, I'm happy to open an issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/511 **Author:** [@billdenney](https://github.com/billdenney) **Created:** 4/5/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `memory-safety-fixes` --- ### 📝 Commits (5) - [`88a44a9`](https://github.com/jmcnamara/libxlsxwriter/commit/88a44a9ffafc22d4719f73aa4ac5f4010166fb45) worksheet: fix uint8_t counter overflow in validation list functions - [`eeb2d89`](https://github.com/jmcnamara/libxlsxwriter/commit/eeb2d89c141305a3f8a71cff164e8925a9004542) worksheet: fix quadratic over-allocation in _set_default_table_columns - [`de6aaee`](https://github.com/jmcnamara/libxlsxwriter/commit/de6aaee23662850b22e103c8cb3ee610629a8634) utility: guarantee null termination after strncpy in lxw_rowcol_to_formula_abs - [`da95035`](https://github.com/jmcnamara/libxlsxwriter/commit/da95035568c6fe81efd2e061ddf0a4932921531f) utility: use size_t index and unsigned char cast in lxw_str_tolower - [`74e5406`](https://github.com/jmcnamara/libxlsxwriter/commit/74e54063af5ee198b3e7520bba8f88ecb8c7d0cc) Changes: document memory safety fixes for 1.2.5 ### 📊 Changes **4 files changed** (+94 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `Changes.txt` (+36 -0) 📝 `src/utility.c` (+3 -2) 📝 `src/worksheet.c` (+4 -4) ➕ `test/unit/worksheet/test_worksheet_validation_list_overflow.c` (+51 -0) </details> ### 📄 Description This was intended as a simple fix for some possible memory issues identified by AI. If it needs discussion, I'm happy to open an issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>