[PR #466] [MERGED] #465 change from defineCMacro to addCMacro #500

New issue

Closed

opened 2026-05-05 12:17:37 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:17:37 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/466
Author: @zigster64
Created: 12/24/2024
Status: ✅ Merged
Merged: 12/24/2024
Merged by: @jmcnamara

Base: main ← Head: fix-add-c-macro

📝 Commits (1)

f460f5f change from defineCMacro to addCMacro

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 build.zig (+3 -3)

📄 Description

Small change to build.zig due to change in the zig build system, in the way it passes C Macros from the Zig build system to the target

defineCMacro() -> deprecated in favour of -> root_lib.addCMacro()

Recently deprecated & removed from the zig compiler
142471fcc4

This change has no effect on libxlswriter itself - its a zig issue, no a libxlswriter issue

Tested - built using a patched zig-libxlswriter, and added to my app for end 2 end test to generate spreadsheets.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/466 **Author:** [@zigster64](https://github.com/zigster64) **Created:** 12/24/2024 **Status:** ✅ Merged **Merged:** 12/24/2024 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `main` ← **Head:** `fix-add-c-macro` --- ### 📝 Commits (1) - [`f460f5f`](https://github.com/jmcnamara/libxlsxwriter/commit/f460f5f517a929c6fbe4200795480927655015f6) change from defineCMacro to addCMacro ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `build.zig` (+3 -3) </details> ### 📄 Description Small change to build.zig due to change in the zig build system, in the way it passes C Macros from the Zig build system to the target defineCMacro() -> deprecated in favour of -> root_lib.addCMacro() Recently deprecated & removed from the zig compiler https://github.com/ziglang/zig/commit/142471fcc46070326526e3976f0150fe734df0b6 This change has no effect on libxlswriter itself - its a zig issue, no a libxlswriter issue Tested - built using a patched zig-libxlswriter, and added to my app for end 2 end test to generate spreadsheets. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>