[GH-ISSUE #60] Another MSVC++ 2010 issue with variable declaration in packager.c #50

New issue

Closed

opened 2026-05-05 11:31:49 -06:00 by gitea-mirror · 2 comments

gitea-mirror commented

2026-05-05 11:31:49 -06:00

Owner

Originally created by @utelle on GitHub (Jul 4, 2016).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/60

Originally assigned to: @jmcnamara on GitHub.

Since MSVC++ 2010 does not support the C99 standard, variable declaration have to be placed at the beginning of scope block. Therefore packager.c doesn't compile properly due to lines 58 and 59 declaring a variable after some executable code:

58:    /* Use the native Win32 file handling functions with minizip. */
59:    zlib_filefunc64_def filefunc;

This is allowed for C99, but not for C89. Moving these 2 lines a bit up, for example just below line 47

47: wchar_t wide_filename[_MAX_PATH + 1] = L"";

solves the problem.

Originally created by @utelle on GitHub (Jul 4, 2016). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/60 Originally assigned to: @jmcnamara on GitHub. Since MSVC++ 2010 does not support the C99 standard, variable declaration have to be placed at the beginning of scope block. Therefore `packager.c` doesn't compile properly due to lines 58 and 59 declaring a variable after some executable code: ``` 58: /* Use the native Win32 file handling functions with minizip. */ 59: zlib_filefunc64_def filefunc; ``` This is allowed for C99, but not for C89. Moving these 2 lines a bit up, for example just **below** line 47 ``` 47: wchar_t wide_filename[_MAX_PATH + 1] = L""; ``` solves the problem.