[PR #383] [MERGED] Improve buffer support #475

New issue

Closed

opened 2026-05-05 12:16:55 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:16:55 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/383
Author: @mohd-akram
Created: 11/12/2022
Status: ✅ Merged
Merged: 11/12/2022
Merged by: @jmcnamara

Base: main ← Head: improve-buf-support

📝 Commits (1)

86bbc4a Improve buffer support

📊 Changes

3 files changed (+147 additions, -74 deletions)

View changed files

📝 include/xlsxwriter/worksheet.h (+2 -1)
📝 src/packager.c (+112 -49)
📝 src/worksheet.c (+33 -24)

📄 Description

macOS does not like rewinding and reading from a memstream (it messes up the buffer) which is fair enough - per spec, open_memstream() returns a write-only stream. This PR ensures the buffer is read from directly to avoid this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/383 **Author:** [@mohd-akram](https://github.com/mohd-akram) **Created:** 11/12/2022 **Status:** ✅ Merged **Merged:** 11/12/2022 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `main` ← **Head:** `improve-buf-support` --- ### 📝 Commits (1) - [`86bbc4a`](https://github.com/jmcnamara/libxlsxwriter/commit/86bbc4a1e976a49ce72f89e15795a2bfabcbcf33) Improve buffer support ### 📊 Changes **3 files changed** (+147 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `include/xlsxwriter/worksheet.h` (+2 -1) 📝 `src/packager.c` (+112 -49) 📝 `src/worksheet.c` (+33 -24) </details> ### 📄 Description macOS does not like rewinding and reading from a memstream (it messes up the buffer) which is fair enough - per spec, `open_memstream()` returns a write-only stream. This PR ensures the buffer is read from directly to avoid this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>