[PR #359] [MERGED] Link minizip and crypto in C++ test if required #472

New issue

Closed

opened 2026-05-05 12:16:47 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:16:47 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/359
Author: @sjmulder
Created: 11/20/2021
Status: ✅ Merged
Merged: 11/20/2021
Merged by: @jmcnamara

Base: main ← Head: pr/cpptest-libs

📝 Commits (1)

7445bde Link minizip and crypto in C++ test if required

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 test/cpp/Makefile (+8 -0)

📄 Description

Setting USE_SYSTEM_MINIZIP and USE_OPENSSL_MD5 causes minizip and crypto
respectively to become dependencies of libxlsxwriter, hence then they
need to be linked in the C++ test, too.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/359 **Author:** [@sjmulder](https://github.com/sjmulder) **Created:** 11/20/2021 **Status:** ✅ Merged **Merged:** 11/20/2021 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `main` ← **Head:** `pr/cpptest-libs` --- ### 📝 Commits (1) - [`7445bde`](https://github.com/jmcnamara/libxlsxwriter/commit/7445bdef8f14acadbf9b59fe22bccb7c97656283) Link minizip and crypto in C++ test if required ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `test/cpp/Makefile` (+8 -0) </details> ### 📄 Description Setting USE_SYSTEM_MINIZIP and USE_OPENSSL_MD5 causes minizip and crypto respectively to become dependencies of libxlsxwriter, hence then they need to be linked in the C++ test, too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>