[PR #349] [MERGED] Support user-supplied config.mk #469

New issue

Closed

opened 2026-05-05 12:16:41 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:16:41 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/349
Author: @sjmulder
Created: 7/27/2021
Status: ✅ Merged
Merged: 7/29/2021
Merged by: @jmcnamara

Base: main ← Head: pr/config-mk

📝 Commits (1)

252b460 Support user-supplied config.mk

📊 Changes

11 files changed (+23 additions, -0 deletions)

View changed files

📝 Makefile (+3 -0)
📝 docs/Makefile (+2 -0)
📝 examples/Makefile (+2 -0)
📝 src/Makefile (+2 -0)
📝 test/functional/src/Makefile (+2 -0)
📝 test/unit/Makefile (+2 -0)
📝 test/unit/Makefile.unit (+2 -0)
📝 third_party/dtoa/Makefile (+2 -0)
📝 third_party/md5/Makefile (+2 -0)
📝 third_party/minizip/Makefile (+2 -0)
📝 third_party/tmpfileplus/Makefile (+2 -0)

📄 Description

Users and developers may have to make some make configuration changes
to suit the local environment, for example for setting up library search
paths. To avoid having to type arguments to make every time temporary local
changes may be made to Makefiles but this presents two problems:

There are many Makefiles used in this project that must be edited.
It clutters the git status and makes it easy to accidentally commit
such a local Makefile change.

This commit adds includes for an optional, top level config.mk for
local changes, ignored by version control.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/349 **Author:** [@sjmulder](https://github.com/sjmulder) **Created:** 7/27/2021 **Status:** ✅ Merged **Merged:** 7/29/2021 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `main` ← **Head:** `pr/config-mk` --- ### 📝 Commits (1) - [`252b460`](https://github.com/jmcnamara/libxlsxwriter/commit/252b460593fe8c43d1ecc629279142bd6e162b01) Support user-supplied config.mk ### 📊 Changes **11 files changed** (+23 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+3 -0) 📝 `docs/Makefile` (+2 -0) 📝 `examples/Makefile` (+2 -0) 📝 `src/Makefile` (+2 -0) 📝 `test/functional/src/Makefile` (+2 -0) 📝 `test/unit/Makefile` (+2 -0) 📝 `test/unit/Makefile.unit` (+2 -0) 📝 `third_party/dtoa/Makefile` (+2 -0) 📝 `third_party/md5/Makefile` (+2 -0) 📝 `third_party/minizip/Makefile` (+2 -0) 📝 `third_party/tmpfileplus/Makefile` (+2 -0) </details> ### 📄 Description Users and developers may have to make some `make` configuration changes to suit the local environment, for example for setting up library search paths. To avoid having to type arguments to `make` every time temporary local changes may be made to Makefiles but this presents two problems: 1. There are many Makefiles used in this project that must be edited. 2. It clutters the git status and makes it easy to accidentally commit such a local Makefile change. This commit adds includes for an optional, top level `config.mk` for local changes, ignored by version control. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>