[PR #316] [CLOSED] Add missing zlib.h include, add library version #461

New issue

Closed

opened 2026-05-05 12:16:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:16:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/316
Author: @manisandro
Created: 11/13/2020
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

96bd684 Add missing include for zlib.h
1e659ac Add a library version

📊 Changes

2 files changed (+9 additions, -0 deletions)

View changed files

📝 CMakeLists.txt (+8 -0)
📝 src/packager.c (+1 -0)

📄 Description

Two patches I've applied while packaging libxlswriter for Fedora.

I needed to include zlib.h, otherwise I get Z_DEFAULT_COMPRESSION not defined.
It's good practice to version the library, so that dependent packages can keep track of which library version they are compatible with.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/316 **Author:** [@manisandro](https://github.com/manisandro) **Created:** 11/13/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`96bd684`](https://github.com/jmcnamara/libxlsxwriter/commit/96bd684250f4d7955308cb5b674d3e2b9f8972b2) Add missing include for zlib.h - [`1e659ac`](https://github.com/jmcnamara/libxlsxwriter/commit/1e659aca6a20419c11abbbb1f5570e36b1e3eac1) Add a library version ### 📊 Changes **2 files changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+8 -0) 📝 `src/packager.c` (+1 -0) </details> ### 📄 Description Hi Two patches I've applied while packaging libxlswriter for Fedora. - I needed to include `zlib.h`, otherwise I get `Z_DEFAULT_COMPRESSION` not defined. - It's good practice to version the library, so that dependent packages can keep track of which library version they are compatible with. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>