[PR #298] [CLOSED] Add function lxw_exists_control_chars to utility #459

New issue

Closed

opened 2026-05-05 12:16:24 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:16:24 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/298
Author: @viest
Created: 6/29/2020
Status: ❌ Closed

Base: master ← Head: viest

📝 Commits (2)

18846e5 Add function lxw_exists_control_chars to utility
897b652 unit test

📊 Changes

5 files changed (+174 additions, -9 deletions)

View changed files

📝 include/xlsxwriter/utility.h (+5 -0)
📝 src/shared_strings.c (+1 -3)
📝 src/utility.c (+72 -0)
📝 src/worksheet.c (+2 -6)
➕ test/unit/utility/test_exists_control_chars.c (+94 -0)

📄 Description

Using the CPU instruction set to optimize the control of character retrieval, when the character length exceeds or equals 16, it has a significant performance improvement.

Number of cells

500,000 rows * 20 columns

Char length

Before

After

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/298 **Author:** [@viest](https://github.com/viest) **Created:** 6/29/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `viest` --- ### 📝 Commits (2) - [`18846e5`](https://github.com/jmcnamara/libxlsxwriter/commit/18846e5606f68830d684ba9fde505eb19c16ee2d) Add function lxw_exists_control_chars to utility - [`897b652`](https://github.com/jmcnamara/libxlsxwriter/commit/897b6529e0e7f1b3d8b85f6bfa75ccae53073c32) unit test ### 📊 Changes **5 files changed** (+174 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `include/xlsxwriter/utility.h` (+5 -0) 📝 `src/shared_strings.c` (+1 -3) 📝 `src/utility.c` (+72 -0) 📝 `src/worksheet.c` (+2 -6) ➕ `test/unit/utility/test_exists_control_chars.c` (+94 -0) </details> ### 📄 Description Using the CPU instruction set to optimize the control of character retrieval, when the character length exceeds or equals 16, it has a significant performance improvement. ### Number of cells 500,000 rows * 20 columns ### Char length 26 ### Before <img width="2272" alt="1" src="https://user-images.githubusercontent.com/14308107/86028217-35c7bd80-ba64-11ea-9f95-f55108038a53.png"> ### After <img width="1955" alt="2" src="https://user-images.githubusercontent.com/14308107/86028264-4710ca00-ba64-11ea-8a4b-d691f8f2548f.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>