[PR #253] [CLOSED] add LXW_VERSION_ID macro #451

New issue

Closed

opened 2026-05-05 12:16:15 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:16:15 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/253
Author: @remicollet
Created: 11/19/2019
Status: ❌ Closed

Base: master ← Head: issue-verid

📝 Commits (1)

bd78d5b add LXW_VERSION_ID macro

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 include/xlsxwriter.h (+2 -0)

📄 Description

API changes are quite difficult to track, thus having to use strange hacks such as https://github.com/viest/php-ext-xlswriter/pull/199

Having such a macro will make code compatibility simpler, ex:

#ifdef LXW_VERSION_ID >= 80008
        if (STAILQ_EMPTY(worksheet->image_props)
#else
        if (STAILQ_EMPTY(worksheet->image_data)
#endif

And also easier to clean, when minimal version will be raised.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/253 **Author:** [@remicollet](https://github.com/remicollet) **Created:** 11/19/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `issue-verid` --- ### 📝 Commits (1) - [`bd78d5b`](https://github.com/jmcnamara/libxlsxwriter/commit/bd78d5b163df01e7a37baf159c3a8fab029f0a86) add LXW_VERSION_ID macro ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `include/xlsxwriter.h` (+2 -0) </details> ### 📄 Description API changes are quite difficult to track, thus having to use strange hacks such as https://github.com/viest/php-ext-xlswriter/pull/199 Having such a macro will make code compatibility simpler, ex: ``` #ifdef LXW_VERSION_ID >= 80008 if (STAILQ_EMPTY(worksheet->image_props) #else if (STAILQ_EMPTY(worksheet->image_data) #endif ``` And also easier to clean, when minimal version will be raised. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>