[PR #247] [MERGED] CMake: Add /utf-8 MSVC compiler option for non-UTF-8 locales #450

New issue

Closed

opened 2026-05-05 12:16:15 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:16:15 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/247
Author: @myd7349
Created: 9/14/2019
Status: ✅ Merged
Merged: 9/16/2019
Merged by: @jmcnamara

Base: master ← Head: specify-charset

📝 Commits (1)

d3f3aac CMake: Add /utf-8 MSVC compiler option for non-UTF-8 locales

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 CMakeLists.txt (+6 -1)

📄 Description

On non-UTF-8 locales(GBK, for example), those CJK characters in theme.c cause build errors:

src\theme.c(38): error C2059: syntax error: '>'
src\theme.c(38): error C2001: newline in constant
src\theme.c(72): error C2001: newline in constant

This patch also removes unknown option /O0. GCC's -O0 equivalent should be /Ot(https://github.com/swig/cccl/blob/master/cccl). Do you mean /Od(the default) here?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/247 **Author:** [@myd7349](https://github.com/myd7349) **Created:** 9/14/2019 **Status:** ✅ Merged **Merged:** 9/16/2019 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `specify-charset` --- ### 📝 Commits (1) - [`d3f3aac`](https://github.com/jmcnamara/libxlsxwriter/commit/d3f3aac26ac9db7866b297f9a5b85a0fee5bf571) CMake: Add /utf-8 MSVC compiler option for non-UTF-8 locales ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+6 -1) </details> ### 📄 Description On non-UTF-8 locales(GBK, for example), those CJK characters in `theme.c` cause build errors: ``` src\theme.c(38): error C2059: syntax error: '>' src\theme.c(38): error C2001: newline in constant src\theme.c(72): error C2001: newline in constant ``` This patch also removes unknown option `/O0`. GCC's `-O0` equivalent should be `/Ot`(https://github.com/swig/cccl/blob/master/cccl). Do you mean `/Od`(the default) here? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>