[PR #246] [MERGED] Patch for issue #243, by specifying the new policy for <PackageName>_ROOT. #449

New issue

Closed

opened 2026-05-05 12:16:08 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:16:08 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/246
Author: @Alexhuszagh
Created: 9/3/2019
Status: ✅ Merged
Merged: 9/8/2019
Merged by: @jmcnamara

Base: master ← Head: master

📝 Commits (1)

c5889d3 Patch for issue #243, by specifying the new policy for _ROOT.

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 CMakeLists.txt (+10 -0)

📄 Description

This should patch issue #243, and potentially #242.

I've tested the following code produces no warnings, and respects the ZLIB_ROOT variable on the following CMake versions (on Linux, x86-64):

3.14.5
3.12.0
3.11.4 (The last release prior to 3.12.0)
3.9.2 (An arbitrary older release)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/246 **Author:** [@Alexhuszagh](https://github.com/Alexhuszagh) **Created:** 9/3/2019 **Status:** ✅ Merged **Merged:** 9/8/2019 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`c5889d3`](https://github.com/jmcnamara/libxlsxwriter/commit/c5889d3d090f6c131b2fd819d8c97822f2d2871e) Patch for issue #243, by specifying the new policy for <PackageName>_ROOT. ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+10 -0) </details> ### 📄 Description This should patch issue #243, and potentially #242. I've tested the following code produces no warnings, and respects the `ZLIB_ROOT` variable on the following CMake versions (on Linux, x86-64): - 3.14.5 - 3.12.0 - 3.11.4 (The last release prior to 3.12.0) - 3.9.2 (An arbitrary older release) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>