[PR #207] [CLOSED] Update FindZLib CMake module #438

New issue

Closed

opened 2026-05-05 12:15:51 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:51 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/207
Author: @evanmiller
Created: 12/12/2018
Status: ❌ Closed

Base: master ← Head: cmake-find-zlib

📝 Commits (1)

9cd3073 Update FindZLib CMake module

📊 Changes

4 files changed (+621 additions, -92 deletions)

View changed files

➕ cmake/FindPackageHandleStandardArgs.cmake (+386 -0)
➕ cmake/FindPackageMessage.cmake (+47 -0)
📝 cmake/FindZLIB.cmake (+117 -92)
➕ cmake/SelectLibraryConfigurations.cmake (+71 -0)

📄 Description

The current version errors out on macOS 10.14 Mojave:

$ cmake .
CMake Error at cmake/FindPackage.cmake:180 (message):
  Unable to find requested ZLIB libraries.
Call Stack (most recent call first):
  cmake/FindZLIB.cmake:123 (RequiredPackageFound)
  CMakeLists.txt:163 (find_package)


zlib version:
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
ZLIB_LIBRARY
    linked by target "xlsxwriter" in directory /XXX/libxlsxwriter

-- Configuring incomplete, errors occurred!

This commit includes the FindZLib module from CMake 3.13, as well as additional scripts that FindZLib depends on.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/207 **Author:** [@evanmiller](https://github.com/evanmiller) **Created:** 12/12/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cmake-find-zlib` --- ### 📝 Commits (1) - [`9cd3073`](https://github.com/jmcnamara/libxlsxwriter/commit/9cd307341f8231dc289df45a084070a42f98c0d3) Update FindZLib CMake module ### 📊 Changes **4 files changed** (+621 additions, -92 deletions) <details> <summary>View changed files</summary> ➕ `cmake/FindPackageHandleStandardArgs.cmake` (+386 -0) ➕ `cmake/FindPackageMessage.cmake` (+47 -0) 📝 `cmake/FindZLIB.cmake` (+117 -92) ➕ `cmake/SelectLibraryConfigurations.cmake` (+71 -0) </details> ### 📄 Description The current version errors out on macOS 10.14 Mojave: ``` $ cmake . CMake Error at cmake/FindPackage.cmake:180 (message): Unable to find requested ZLIB libraries. Call Stack (most recent call first): cmake/FindZLIB.cmake:123 (RequiredPackageFound) CMakeLists.txt:163 (find_package) zlib version: CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: ZLIB_LIBRARY linked by target "xlsxwriter" in directory /XXX/libxlsxwriter -- Configuring incomplete, errors occurred! ``` This commit includes the FindZLib module from CMake 3.13, as well as additional scripts that FindZLib depends on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>