[PR #188] [MERGED] Fix for spurious PDB renaming. #437

New issue

Closed

opened 2026-05-05 12:15:51 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:51 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/188
Author: @Alexhuszagh
Created: 6/19/2018
Status: ✅ Merged
Merged: 7/18/2018
Merged by: @jmcnamara

Base: master ← Head: master

📝 Commits (1)

2dfd9da Fix for 9a78c323a9, which introduced the pdb renaming spuriously.

📊 Changes

1 file changed (+1 additions, -11 deletions)

View changed files

📝 CMakeLists.txt (+1 -11)

📄 Description

I tracked down the origin of the code for the PDB renaming, since it retrospect it seemed suspect to me. It was part of the following commit, which added various hardcoded values for certain common use cases we've had to subsequently remove for good reason.

The more I looked at the code, the more I realized that re-writing the PDB (symbol info) for a specific build to a global project directory is a bad idea, and that was should be only installing from the project-specific PDB anyway.

Hence, the changes. I'll be careful to review code more carefully before signing off on it in the future. This fixes #175.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/188 **Author:** [@Alexhuszagh](https://github.com/Alexhuszagh) **Created:** 6/19/2018 **Status:** ✅ Merged **Merged:** 7/18/2018 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`2dfd9da`](https://github.com/jmcnamara/libxlsxwriter/commit/2dfd9da7a9045207137814205c919e93a097da9a) Fix for 9a78c323a925c75d8feffb7c3f6a7773e79d2628, which introduced the pdb renaming spuriously. ### 📊 Changes **1 file changed** (+1 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+1 -11) </details> ### 📄 Description I tracked down the origin of the code for the PDB renaming, since it retrospect it seemed suspect to me. It was part of the following [commit](https://github.com/jmcnamara/libxlsxwriter/commit/9a78c323a925c75d8feffb7c3f6a7773e79d2628#diff-af3b638bc2a3e6c650974192a53c7291), which added various hardcoded values for certain common use cases we've had to subsequently remove for good reason. The more I looked at the code, the more I realized that re-writing the PDB (symbol info) for a specific build to a global project directory is a bad idea, and that was should be only installing from the project-specific PDB anyway. Hence, the changes. I'll be careful to review code more carefully before signing off on it in the future. This fixes #175. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>