[PR #171] [CLOSED] Bug fix for #166, adding multiarch support. #430

New issue

Closed

opened 2026-05-05 12:15:42 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:42 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/171
Author: @Alexhuszagh
Created: 4/27/2018
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

c077452 Bug fix for #166, adding multiarch support and build toolchains for i686 on x86_64 systems.

📊 Changes

2 files changed (+34 additions, -9 deletions)

View changed files

📝 CMakeLists.txt (+27 -9)
➕ cmake/i686-toolchain.cmake (+7 -0)

📄 Description

On Linux systems this:

Correctly installs to the proper library directory (lib for 32-bit libraries, lib64 or 64-bit)
Includes an i686 generator to allow building 32-bit libraries on x86_64.
Updates the CMake documentation to reflect these changes.

For example, to build a 32-bit library on a x86_64 Linux, you may do:

mkdir build && cd build
cmake .. -DBUILD_TESTS=ON -DCMAKE_BUILD_TYPE=Release \
    -DCMAKE_TOOLCHAIN_FILE=../cmake/i686-toolchain.cmake
make
make test
make install

It would technically be possible to use an option to pass to CMake, however, this would not work if libxlsxwriter is used as a dependency in another project, while a toolchain with the proper flags for libxlsxwriter (CMAKE_C_FLAGS) and potentially for other projects that use libxlsxwriter (CMAKE_CXX_FLAGS and CMAKE_ASM_FLAGS) would prevent any discontinuities between the binary architecture of the libxlsxwriter target and that of the parent project.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/171 **Author:** [@Alexhuszagh](https://github.com/Alexhuszagh) **Created:** 4/27/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`c077452`](https://github.com/jmcnamara/libxlsxwriter/commit/c07745225df6f5e20d24465772c02c99d9620c87) Bug fix for #166, adding multiarch support and build toolchains for i686 on x86_64 systems. ### 📊 Changes **2 files changed** (+34 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+27 -9) ➕ `cmake/i686-toolchain.cmake` (+7 -0) </details> ### 📄 Description On Linux systems this: - Correctly installs to the proper library directory (lib for 32-bit libraries, lib64 or 64-bit) - Includes an i686 generator to allow building 32-bit libraries on x86_64. - Updates the CMake documentation to reflect these changes. For example, to build a 32-bit library on a x86_64 Linux, you may do: ```bash mkdir build && cd build cmake .. -DBUILD_TESTS=ON -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_TOOLCHAIN_FILE=../cmake/i686-toolchain.cmake make make test make install ``` It would technically be possible to use an option to pass to CMake, however, this would not work if `libxlsxwriter` is used as a dependency in another project, while a toolchain with the proper flags for libxlsxwriter (`CMAKE_C_FLAGS`) and potentially for other projects that use libxlsxwriter (`CMAKE_CXX_FLAGS` and `CMAKE_ASM_FLAGS`) would prevent any discontinuities between the binary architecture of the libxlsxwriter target and that of the parent project. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>