[PR #162] [MERGED] Fix for Issue #153 #428

New issue

Closed

opened 2026-05-05 12:15:36 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:36 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/162
Author: @Alexhuszagh
Created: 4/19/2018
Status: ✅ Merged
Merged: 4/23/2018
Merged by: @jmcnamara

Base: master ← Head: master

📝 Commits (1)

01ef9ab PR for issue #153, ensure the use of wide paths works without _UNICODE defined.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/packager.c (+1 -1)

📄 Description

Patch to fix issue #153. As my Windows development machine is currently down, I cannot comprehensively test it, but it's been testing using cross-compilation on Fedora MinGW without issues.

Steps. to confirm it works (cross-compiling):

git clone https://github.com/Alexhuszagh/libxlsxwriter && cd libxlsxwriter
mkdir build && cd build
wget https://github.com/madler/zlib/archive/v1.2.11.zip
unzip v1.2.11.zip
cd zlib-1.2.11
cmake . # -DCMAKE_C_FLAGS="-D_UNICODE"
cd ..
cmake .. -DBUILD_TESTS=ON -DZLIB_INCLUDE_DIR=zlib-1.2.11 -DZLIB_LIBRARY=zlib-1.2.11/libzlibstatic.a # -DCMAKE_C_FLAGS="-D_UNICODE"

I've tried all 4 forms of the _UNICODE combinations cross-compiling, so it should work.

Thoughts @RalfKubis, @jmcnamara?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/162 **Author:** [@Alexhuszagh](https://github.com/Alexhuszagh) **Created:** 4/19/2018 **Status:** ✅ Merged **Merged:** 4/23/2018 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`01ef9ab`](https://github.com/jmcnamara/libxlsxwriter/commit/01ef9ab4875b577051c38b05d62caf4660e037a7) PR for issue #153, ensure the use of wide paths works without _UNICODE defined. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/packager.c` (+1 -1) </details> ### 📄 Description Patch to fix issue #153. As my Windows development machine is currently down, I cannot comprehensively test it, but it's been testing using cross-compilation on Fedora MinGW without issues. Steps. to confirm it works (cross-compiling): 1. `git clone https://github.com/Alexhuszagh/libxlsxwriter && cd libxlsxwriter` 2. `mkdir build && cd build` 3. `wget https://github.com/madler/zlib/archive/v1.2.11.zip` 4. `unzip v1.2.11.zip` 5. `cd zlib-1.2.11` 6. `cmake . # -DCMAKE_C_FLAGS="-D_UNICODE"` 7. `cd ..` 8. `cmake .. -DBUILD_TESTS=ON -DZLIB_INCLUDE_DIR=zlib-1.2.11 -DZLIB_LIBRARY=zlib-1.2.11/libzlibstatic.a # -DCMAKE_C_FLAGS="-D_UNICODE"` I've tried all 4 forms of the `_UNICODE` combinations cross-compiling, so it should work. Thoughts @RalfKubis, @jmcnamara? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>