[PR #134] [MERGED] Forgot to include 'FindMINIZIP' module to find system minizip #427

New issue

Closed

opened 2026-05-05 12:15:36 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:36 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/134
Author: @Alexhuszagh
Created: 10/24/2017
Status: ✅ Merged
Merged: 10/25/2017
Merged by: @jmcnamara

Base: master ← Head: master

📝 Commits (1)

89d7eba Forgot to include 'FindMINIZIP' module to find system minizip

📊 Changes

1 file changed (+121 additions, -0 deletions)

View changed files

➕ cmake/FindMINIZIP.cmake (+121 -0)

📄 Description

Very sorry, forgot to include a module in my PR. This is required to find the system minizip installation.

During configuration, you can call find_package(MINIZIP) to locate the includes and libraries for minizip, since CMake does not bundle support for minizip internally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/134 **Author:** [@Alexhuszagh](https://github.com/Alexhuszagh) **Created:** 10/24/2017 **Status:** ✅ Merged **Merged:** 10/25/2017 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`89d7eba`](https://github.com/jmcnamara/libxlsxwriter/commit/89d7eba6e0c34d51ca5ca7201d6c7d6b8a8f428b) Forgot to include 'FindMINIZIP' module to find system minizip ### 📊 Changes **1 file changed** (+121 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `cmake/FindMINIZIP.cmake` (+121 -0) </details> ### 📄 Description Very sorry, forgot to include a module in my PR. This is required to find the system minizip installation. During configuration, you can call `find_package(MINIZIP)` to locate the includes and libraries for minizip, since CMake does not bundle support for minizip internally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>