[PR #133] [MERGED] Add system minizip support to CMakeLists #424

New issue

Closed

opened 2026-05-05 12:15:31 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:31 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/133
Author: @Alexhuszagh
Created: 10/24/2017
Status: ✅ Merged
Merged: 10/24/2017
Merged by: @jmcnamara

Base: master ← Head: minizip

📝 Commits (2)

a9210bc Simplified and more elegant CMakeLists
4d7db9a Add system minizip support to CMakeLists

📊 Changes

1 file changed (+64 additions, -38 deletions)

View changed files

📝 CMakeLists.txt (+64 -38)

📄 Description

First commit fixes #131, which simplifies linking to xlsxwriter with multiple dependencies
Second commit fixes #119, by adding the USE_SYSTEM_MINIZIP flag, which by default is off but can be specified during CMake configuration using -DUSE_SYSTEM_MINIZIP=ON.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/133 **Author:** [@Alexhuszagh](https://github.com/Alexhuszagh) **Created:** 10/24/2017 **Status:** ✅ Merged **Merged:** 10/24/2017 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `minizip` --- ### 📝 Commits (2) - [`a9210bc`](https://github.com/jmcnamara/libxlsxwriter/commit/a9210bc04b9626bd0d3cb8fd6a867cc41fdcf872) Simplified and more elegant CMakeLists - [`4d7db9a`](https://github.com/jmcnamara/libxlsxwriter/commit/4d7db9abe552aad80d0fda8b5b84491a4241cc5a) Add system minizip support to CMakeLists ### 📊 Changes **1 file changed** (+64 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+64 -38) </details> ### 📄 Description - First commit fixes #131, which simplifies linking to xlsxwriter with multiple dependencies - Second commit fixes #119, by adding the `USE_SYSTEM_MINIZIP` flag, which by default is off but can be specified during CMake configuration using `-DUSE_SYSTEM_MINIZIP=ON`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>