[PR #128] [MERGED] MSVC and Shared Linkage Bug Fixes #421

New issue

Closed

opened 2026-05-05 12:15:29 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:29 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/128
Author: @Alexhuszagh
Created: 10/18/2017
Status: ✅ Merged
Merged: 10/18/2017
Merged by: @jmcnamara

Base: master ← Head: master

📝 Commits (2)

bf6e50d Link ZLIB to library (required for shared libraries)
a975b41 Patch for MSVC CRT secure warnings

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 CMakeLists.txt (+6 -0)

📄 Description

Patch for issues discovered in #115, as well as a patch to remove numerous superfluous errors by MSVC by setting the _CRT_SECURE_NO_WARNINGS flag (MSVC warns for functions that may lead to a buffer overflow, but warns for functions fread and snprintf, which already require you to provide to length of the destination buffer, so the CRT warnings are effectively useless IMO, especially when you require the use of standard C/POSIX functions).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/128 **Author:** [@Alexhuszagh](https://github.com/Alexhuszagh) **Created:** 10/18/2017 **Status:** ✅ Merged **Merged:** 10/18/2017 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`bf6e50d`](https://github.com/jmcnamara/libxlsxwriter/commit/bf6e50d6b283cd927dce41e896ca346e9e3afdfb) Link ZLIB to library (required for shared libraries) - [`a975b41`](https://github.com/jmcnamara/libxlsxwriter/commit/a975b41705602733dec7d7fc0488692968231732) Patch for MSVC CRT secure warnings ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+6 -0) </details> ### 📄 Description Patch for issues discovered in #115, as well as a patch to remove numerous superfluous errors by MSVC by setting the `_CRT_SECURE_NO_WARNINGS` flag (MSVC warns for functions that may lead to a buffer overflow, but warns for functions `fread` and `snprintf`, which already require you to provide to length of the destination buffer, so the CRT warnings are effectively useless IMO, especially when you require the use of standard C/POSIX functions). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>