[PR #109] [MERGED] Fixes 3 Issues #418

New issue

Closed

opened 2026-05-05 12:15:21 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 12:15:21 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/109
Author: @Alexhuszagh
Created: 7/11/2017
Status: ✅ Merged
Merged: 7/11/2017
Merged by: @jmcnamara

Base: master ← Head: master

📝 Commits (3)

de4afb4 Updated CMakeLists to fix iowin32.c with MSVC
0278e18 Updated CTest to work with MSVC
dd1d18d Added integrations for Tea-CI (MinGW, using a MSYS2-like environment, and AppVeyor, an MSVC CI service.

📊 Changes

4 files changed (+122 additions, -11 deletions)

View changed files

➕ .drone.yml (+18 -0)
📝 CMakeLists.txt (+15 -5)
➕ appveyor.yml (+38 -0)
📝 test/unit/ctest.h (+51 -6)

📄 Description

Hi @jmcnamara, this PR fixes 3 issues we've previously discussed, and adds continual integration for MSYS2 (one that we had not discussed). It's broken into 3 commits accordingly.

Fixes issue 108 so the CMake generation properly includes iowin32.c.
Fixes issue 107 to make unittests work on MSVC.
Adds continual integration for AppVeyor (Visual Studio 2015 and Visual Studio 2017) and Tea-CI (MSYS2).

Combined, this should be good assurance that the CMake builds work on a large variety of platforms, in addition to the Makefile builds, which is especially useful for Visual Studio.

I also need to submit a PR for an example for a CMake example, which I can do later tonight.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jmcnamara/libxlsxwriter/pull/109 **Author:** [@Alexhuszagh](https://github.com/Alexhuszagh) **Created:** 7/11/2017 **Status:** ✅ Merged **Merged:** 7/11/2017 **Merged by:** [@jmcnamara](https://github.com/jmcnamara) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`de4afb4`](https://github.com/jmcnamara/libxlsxwriter/commit/de4afb49f564e24bae39c1689a6e2740fe876d5d) Updated CMakeLists to fix iowin32.c with MSVC - [`0278e18`](https://github.com/jmcnamara/libxlsxwriter/commit/0278e180428e103ecbc3fb081bb51e3f40d6eb20) Updated CTest to work with MSVC - [`dd1d18d`](https://github.com/jmcnamara/libxlsxwriter/commit/dd1d18d49757a912398fe24b6eb1768ad65e2fb2) Added integrations for Tea-CI (MinGW, using a MSYS2-like environment, and AppVeyor, an MSVC CI service. ### 📊 Changes **4 files changed** (+122 additions, -11 deletions) <details> <summary>View changed files</summary> ➕ `.drone.yml` (+18 -0) 📝 `CMakeLists.txt` (+15 -5) ➕ `appveyor.yml` (+38 -0) 📝 `test/unit/ctest.h` (+51 -6) </details> ### 📄 Description Hi @jmcnamara, this PR fixes 3 issues we've previously discussed, and adds continual integration for MSYS2 (one that we had not discussed). It's broken into 3 commits accordingly. 1. Fixes [issue 108](https://github.com/jmcnamara/libxlsxwriter/issues/108) so the CMake generation properly includes iowin32.c. 2. Fixes [issue 107](https://github.com/jmcnamara/libxlsxwriter/issues/107) to make unittests work on MSVC. 3. Adds continual integration for AppVeyor (Visual Studio 2015 and Visual Studio 2017) and [Tea-CI](https://tea-ci.org/Alexhuszagh/libxlsxwriter) (MSYS2). Combined, this should be good assurance that the CMake builds work on a large variety of platforms, in addition to the Makefile builds, which is especially useful for Visual Studio. I also need to submit a PR for an example for a CMake example, which I can do later tonight. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>