mirror of
https://github.com/jmcnamara/libxlsxwriter.git
synced 2026-05-15 14:15:54 -06:00
[PR #68] [CLOSED] [PROPOSAL] ability to specify cell's format without changing cell's content #408
Labels
No labels
awaiting user feedback
bug
cmake
cmake
docs
feature request
in progress
long term
medium term
medium term
pull-request
question
question
ready to close
short term
under investigation
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/libxlsxwriter#408
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jmcnamara/libxlsxwriter/pull/68
Author: @lemmel
Created: 7/19/2016
Status: ❌ Closed
Base:
master← Head:master📝 Commits (1)
68782f6[PROPOSAL] added the ability to specify cells format without changing cells value.📊 Changes
2 files changed (+155 additions, -3 deletions)
View changed files
📝
include/xlsxwriter/worksheet.h(+47 -0)📝
src/worksheet.c(+108 -3)📄 Description
Hi.
I have the need to play with borders and it is easier for me to set the data and the cells format at different time.
So as I found this in the FAQ:
I told myself: why not contribute to that library that is usefull for you (and you seemed a little tired as I readed it through some of your messages).
This is not a real proposal for a pull as:
I just want a small code review, advices, and validation of the way to do it.
Commit message:
[PROPOSAL] added the ability to specify cells format without changing cells value.
I used a "phantom" cell type (NULL_CELL), and altered _insert_cell_list and _insert_cell.
There is still question about how clean a cell (c.f. /*Waiting comment ).
Two public functions are now available:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.