[GH-ISSUE #481] Is there a resource leak problem? #373

Closed
opened 2026-05-05 12:13:13 -06:00 by gitea-mirror · 2 comments
Owner

Originally created by @Zakary-D on GitHub (May 27, 2025).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/481

in third_party/minizip/mztools.c:284:3, use fpOutCD and doesn't free it

Image
Originally created by @Zakary-D on GitHub (May 27, 2025). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/481 in third_party/minizip/mztools.c:284:3, use fpOutCD and doesn't free it <img width="336" alt="Image" src="https://github.com/user-attachments/assets/66922f6e-ef13-4952-bd65-a40e1bcc0ecd" />
Author
Owner

@jmcnamara commented on GitHub (May 27, 2025):

Libxlsxwriter doesn't use mztools.c. It only uses ioapi.c and zip.c from that directory, which is a vendored version of the zlib subdirectory: https://github.com/madler/zlib/tree/develop/contrib/minizip

As far as I can see fpOutCD is closed on line 249 of third_party/minizip/mztools.c so it looks okay to me at first glance but if you think it is an issue you should check if it is fixed upstream and if not report it.

Closing this here since it doesn't affect libxlsxwriter.

<!-- gh-comment-id:2911695396 --> @jmcnamara commented on GitHub (May 27, 2025): Libxlsxwriter doesn't use `mztools.c`. It only uses `ioapi.c` and `zip.c` from that directory, which is a vendored version of the `zlib` subdirectory: https://github.com/madler/zlib/tree/develop/contrib/minizip As far as I can see `fpOutCD` is closed on line 249 of `third_party/minizip/mztools.c` so it looks okay to me at first glance but if you think it is an issue you should check if it is fixed upstream and if not report it. Closing this here since it doesn't affect libxlsxwriter.
Author
Owner

@jmcnamara commented on GitHub (May 29, 2025):

See also: https://github.com/madler/zlib/issues/982

<!-- gh-comment-id:2918904705 --> @jmcnamara commented on GitHub (May 29, 2025): See also: https://github.com/madler/zlib/issues/982
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/libxlsxwriter#373
No description provided.